Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enh/add runner workflow #1390

Merged
merged 2 commits into from
Oct 23, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 59 additions & 0 deletions .github/workflows/deploy-runners.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
name: Build & Deploy Runners

on:
workflow_dispatch:
push:
tags:
- '*beta*'

permissions:
packages: write

jobs:
build:
runs-on: ubuntu-latest
strategy:
matrix:
module: ["runner"]

steps:
- name: get container name
run: |
echo "containername=${{ matrix.module }}" | sed 's/\//-/g' > $GITHUB_ENV
- uses: actions/checkout@v3
with:
ref: ${{ github.event.pull_request.head.sha }}
Comment on lines +23 to +25
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Let's use checkout@v4 and
  • add a comment wat this ref is for (I'd assume this or something equivalent should be the default, right?)

- name: Docker meta (${{ matrix.module }})
id: meta
uses: docker/metadata-action@v4
with:
images: ghcr.io/tum-dev/gocast/${{ env.containername }}
tags: |
type=ref,event=branch
type=ref,event=pr
type=semver,pattern={{version}}
type=sha
flavor: |
latest=true
prefix=
suffix=
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2
- name: Login to DockerHub
uses: docker/login-action@v2
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
- name: Set outputs
id: vars
run: echo "::set-output name=sha_short::$(git rev-parse --short HEAD)"
- name: Build and push Docker images (${{ matrix.module }})
uses: docker/build-push-action@v4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to configure sbom and build provence here.
Example how I did this:
https://github.com/TUM-Dev/NavigaTUM/blob/main/.github/workflows/_docker-build.yml

(This does not have an immediate impact but allows more forensics for some attack scenarios for little to no maintenance-effort as far as I read up on)

with:
context: ./${{ matrix.module }}
pull: true
push: true
build-args: version=${{ github.ref_name }}
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to configure cache-from and related parameters.
Here is an example how to do this: https://docs.docker.com/build/ci/github-actions/cache/#cache-mounts

Likely the builds are already really fast (looking at you, rust), but a few seconds for a few lines...

Loading