Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The idp frontend HTML structure changed recently and broke the check for totp vs iotp.
This caused a failed totp insertion, resulting in an incomplete authentication.
Type of change
Further info
Testing
We have 1500+ Users. Please test your changes thoroughly.
npm run test
locallyAdditional Information
It seems to load the idp TOTP page twice.
The first time, the input field stays empty.
On the second load, the totp token gets inserted.
I don't know why this happens nor how to debug it.