Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipd: Fix checking for totp type #148

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Conversation

hw0lff
Copy link
Contributor

@hw0lff hw0lff commented Sep 2, 2024

Description

The idp frontend HTML structure changed recently and broke the check for totp vs iotp.
This caused a failed totp insertion, resulting in an incomplete authentication.

Type of change

  • Bug fix (non-breaking change which fixes a bug)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that might cause existing functionality to not work as expected)

Further info

  • This change requires a documentation update
  • I updated the documentation accordingly, if required
  • I commented my code where its useful

Testing

We have 1500+ Users. Please test your changes thoroughly.

  • Tested my changes on Firefox
  • Tested my changes on Chromium-Based-Browsers
  • Successfully run npm run test locally

Additional Information

It seems to load the idp TOTP page twice.
The first time, the input field stays empty.
On the second load, the totp token gets inserted.
I don't know why this happens nor how to debug it.

The idp frontend HTML structure changed recently and broke the check for totp vs iotp.
This caused a failed totp insertion, resulting in an incomplete authentication.
@hw0lff hw0lff requested a review from a team as a code owner September 2, 2024 12:09
@hw0lff hw0lff requested a review from Noxdor September 2, 2024 12:09
Copy link
Member

@OliEfr OliEfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you very much.

I am very busy at the moment and try to merge asap.

Oliver

@OliEfr OliEfr merged commit c7b7e94 into TUfast-TUD:main Sep 3, 2024
1 check passed
@OliEfr
Copy link
Member

OliEfr commented Sep 3, 2024

Uploaded it in the webstores. Should take a couple of days until release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants