Skip to content

Commit

Permalink
[TASK] Prevent using "no/low brainer" as wording (#366)
Browse files Browse the repository at this point in the history
* [TASK] Prevent using "no/low brainer" as wording

To quote a post on the typo3-cms-coredev slack on the
intentions of this, which I fully support:

There is nothing like a “no-brainer” or "low-brainer".
Every patch needs to be checked thoroughly.
The word “no-brainer” leads to hasty mergers.
There is a reason why something has to be changed or adapted.
If a change is so obvious, it would have been solved correctly from the very beginning.
There is always a chance that the “no-brainer” is broken anyway.
Please let us use our brains, always. Thank you.

* [TASK] Link to proper section
  • Loading branch information
garvinhicking authored Sep 24, 2024
1 parent 66eeb75 commit 5736026
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion Documentation/CoreMergers/Backport.rst
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ First try to use the Gerrit cherry-pick feature for automatic backporting.

#. Merge the backport

If the backport is a :ref:`Low brainer <Gerrit-low-brainers>` you can vote
If the backport is :ref:`straight-forward and not complex <Gerrit-low-complexity>`, you can vote
:guilabel:`+2` and continue to merge the backport. Otherwise it should be
reviewed by at least one other Core Merger.

Expand Down
11 changes: 6 additions & 5 deletions Documentation/CoreMergers/Review.rst
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,14 @@ there is already a positive vote by another Core Merger.

.. _Gerrit-No-brainers:
.. _Gerrit-Low-brainers:
.. _Gerrit-Low-complexity:

Low brainers
-------------
Patches of low complexity
-------------------------

A Core Merger can give a +2 and submit right away in case of "low-brainers"
(what used to be called "FYI" and relates to changes that are highly
unlikely to negatively impact anything).
A Core Merger can give a +2 and submit right away in case of patches
that are of very low complexity (like spelling corrections, indentation,
or obvious bugs), and are highly unlikely to negatively impact anything.

A Core Merger can give a +2 and wait a bit before submitting
(used to be called "FYI24", "FYI48", ...).
Expand Down

0 comments on commit 5736026

Please sign in to comment.