-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TASK] Overhaul general file structure section #361
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just the first commit of #356 with the suggested changes from the code review already applied |
linawolf
force-pushed
the
task/overhaule-file
branch
from
January 14, 2024 20:54
695e760
to
3a6cf76
Compare
brotkrueml
reviewed
Jan 17, 2024
Co-authored-by: Chris Müller <[email protected]>
Co-authored-by: Chris Müller <[email protected]>
brotkrueml
reviewed
Jan 17, 2024
brotkrueml
reviewed
Jan 17, 2024
linawolf
force-pushed
the
task/overhaule-file
branch
from
January 17, 2024 18:53
accbab7
to
16068ec
Compare
brotkrueml
approved these changes
Jan 18, 2024
linawolf
added a commit
that referenced
this pull request
Jan 21, 2024
* [TASK] Overhaul general file structure section * Update Documentation/GeneralConventions/FileStructure.rst Co-authored-by: Chris Müller <[email protected]> * Update Documentation/GeneralConventions/FileStructure.rst Co-authored-by: Chris Müller <[email protected]> * [TASK] Apply suggestions from code review * [TASK] Apply suggestions from code review --------- Co-authored-by: Chris Müller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.