Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Introduce Makefile and command 'make docs' #370

Merged
merged 2 commits into from
Jan 21, 2024

Conversation

linawolf
Copy link
Member

This is more convenient then having to copy-paste the command all the time

Makefile Outdated Show resolved Hide resolved
@garvinhicking
Copy link
Contributor

Generally I like the idea to add that to each repository that uses the new rendering. One could also add a global command individually, so any project could be rendered, but the convenience in this one as a consistent command is nice!

This is more convenient then having to copy-paste the command all the time
Copy link
Contributor

@brotkrueml brotkrueml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope, we don't want to add a Makefile to all manuals?

CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Show resolved Hide resolved
@linawolf
Copy link
Member Author

I hope, we don't want to add a Makefile to all manuals?

That would be my plan for the official manuals. And I would like to supply a snippet so ppl can add it to their extensions

CONTRIBUTING.rst Outdated Show resolved Hide resolved
@brotkrueml
Copy link
Contributor

I hope, we don't want to add a Makefile to all manuals?

That would be my plan for the official manuals. And I would like to supply a snippet so ppl can add it to their extensions

Then we definitly need to provide a solution for Windows users.

@linawolf
Copy link
Member Author

I am using windows, this runs fine on WSL2 and is preinstalled. I don't know of any windows user that develops TYPO3 but does not use WSL2. And this script is not mandatory, just a convenient shortcut

@brotkrueml
Copy link
Contributor

Okay, then go ahead, you have already an approval.

@brotkrueml
Copy link
Contributor

And: Then we should document the way that works every time.

@brotkrueml
Copy link
Contributor

brotkrueml commented Jan 21, 2024

And to copy/paste: I am using Ctrl + R for searching in the zsh/bash history. It is faster than typing "make docs" manually ;-)

@linawolf
Copy link
Member Author

For those who prefere the Docker command it still works as before...

@linawolf linawolf merged commit 90b9417 into documentation-draft Jan 21, 2024
2 checks passed
@linawolf linawolf deleted the task/make branch January 21, 2024 17:36
@brotkrueml
Copy link
Contributor

... which is not documented here.

@garvinhicking
Copy link
Contributor

garvinhicking commented Jan 21, 2024

We could theoretically add a composer command that executes docker for the official doc repositories. That would then not have a Make/wsl2/cygwin dependency.

We could also have both of course, but I feel render-guides overdid this already.

Providing a rendering shortcut that is

  • used in all official repos
  • easy to run
  • hides potential complexity in those long "docker run" commands
  • documented (couldn't read this yet though!)
  • not a requirement
  • not hindering alternate rendering ways (local, manual)
  • easy to maintain with low overhead

is an improvement to me? I was more used to composer scripts until I joined the project, and I was under the impression "make" was a decission made already.

@brotkrueml
Copy link
Contributor

IMHO Composer scripts should not be used for calling some binary stuff unrelated to PHP itself. There are other ways to do so. If the command is the same for Windows/Linux/Macos, then put it into a file called "render-docs" and that's it.

Just my 2 cents.

@garvinhicking
Copy link
Contributor

We'd have to add render-docs.sh and render-docs.bat then, I think that would be even less elegant than a Makefile or composer script. And clutter some directory if we add more calls to be executed (guides.xml conversion, guides.xml modification, xml linting...). I think we need a central place for it, so either Makefile (as now) or composer. Everything else would have more dependencies (ie "just" or other command runners).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants