Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Add missing attribute project_discussions #437

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

ErHaWeb
Copy link
Contributor

@ErHaWeb ErHaWeb commented Jul 5, 2024

Add attribute project_discussions, as a corresponding GitHub page exists in the context of the news extension from the example.

Add attribute `project_discussions`, as a corresponding GitHub page exists in the context of the news extension from the example.
Copy link
Contributor

@froemken froemken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. But someone else should approve, as discussions are not activated for all GitHub repos by default.

@ErHaWeb
Copy link
Contributor Author

ErHaWeb commented Jul 5, 2024

That's true, but as an extension author you might want to think about whether a discussion page in your own repository makes sense. If you neither have nor want such a page, you can always remove the attribute. For me, this example is more about showing the possibilities.

@garvinhicking garvinhicking merged commit 420e125 into TYPO3-Documentation:main Jul 6, 2024
1 check passed
@garvinhicking
Copy link
Contributor

Thanks, I agree for the example we should show the whole bouqet. Good idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants