-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TASK] Establish a main "PHP architecture" chapter #5242
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch merges "CGl->PHP architecture" and "CGL->PHP best practices" to a general new top level chapter. This should give extension developers general thoughts about separation of concerns and best practices at hand, and documents how core development handles specific PHP related architectural questions.
linawolf
previously approved these changes
Jan 16, 2025
linawolf
approved these changes
Jan 16, 2025
linawolf
approved these changes
Jan 16, 2025
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-13.4 13.4
# Navigate to the new working tree
cd .worktrees/backport-13.4
# Create a new branch
git switch --create backport-5242-to-13.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 1420cd5f7ddecdd86cb9b9386bf82660418ba8e4,518a3879cb9c15109f86a53aff697137eebf6480
# Push it to GitHub
git push --set-upstream origin backport-5242-to-13.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-13.4 Then, create a pull request where the |
linawolf
added a commit
to linawolf/site-intercept
that referenced
this pull request
Jan 16, 2025
linawolf
pushed a commit
that referenced
this pull request
Jan 17, 2025
* [TASK] Establish a main "PHP architecture" chapter The patch merges "CGl->PHP architecture" and "CGL->PHP best practices" to a general new top level chapter. This should give extension developers general thoughts about separation of concerns and best practices at hand, and documents how core development handles specific PHP related architectural questions. * Update Index.rst --------- Co-authored-by: Lina Wolf <[email protected]> (cherry picked from commit c7e4b51)
andreaskienast
pushed a commit
to TYPO3GmbH/site-intercept
that referenced
this pull request
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch merges "CGl->PHP architecture" and
"CGL->PHP best practices" to a general new top
level chapter. This should give extension developers general thoughts about separation of concerns and
best practices at hand, and documents how core
development handles specific PHP related architectural questions.