Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

[TASK] Update list of allowTags #433

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

ErHaWeb
Copy link
Contributor

@ErHaWeb ErHaWeb commented Feb 29, 2024

The allowTags list has changed several times in the past TYPO3 versions. I have noticed the following changes since the current documented version:

TYPO3 v8.6

b,i,u,a,img,br,div,center,pre,font,hr,sub,sup,p,strong,em,li,ul,ol,blockquote,strike,span

TYPO3 v8.7 to 10.3:

b,i,u,a,img,br,div,center,pre,font,hr,sub,sup,p,strong,em,li,ul,ol,blockquote,strike,span,abbr,acronym,dfn

TYPO3 v10.4 to main:

b,i,u,a,img,br,div,center,pre,figure,figcaption,font,hr,sub,sup,p,strong,em,li,ul,ol,blockquote,strike,span,abbr,acronym,dfn

The allowTags list has changed several times in the past TYPO3 versions. I have noticed the following changes since the current documented version:

TYPO3 v8.6
```
b,i,u,a,img,br,div,center,pre,font,hr,sub,sup,p,strong,em,li,ul,ol,blockquote,strike,span
```

TYPO3 v8.7 to 10.3:
```
b,i,u,a,img,br,div,center,pre,font,hr,sub,sup,p,strong,em,li,ul,ol,blockquote,strike,span,abbr,acronym,dfn
```

TYPO3 v10.4 to main:
```
b,i,u,a,img,br,div,center,pre,figure,figcaption,font,hr,sub,sup,p,strong,em,li,ul,ol,blockquote,strike,span,abbr,acronym,dfn
```
@brotkrueml
Copy link
Contributor

brotkrueml commented Feb 29, 2024

@ErHaWeb Do you know where it is defined? Maybe linking to the source is better than adjusting it every time or having outdated information.

@brotkrueml brotkrueml self-requested a review February 29, 2024 18:11
@garvinhicking
Copy link
Contributor

It's here:

https://github.com/TYPO3/typo3/blob/main/typo3/sysext/core/Classes/Html/RteHtmlParser.php#L51

However, then we would also have to adapt the link with the line number for every TYPO3-release, won't we? So maybe we better copy+paste it than to have people follow a link and need to check the whole github UI?

Luckily since 10.4 it didn't change, so we could just backport this PR down to 11.5, 12.4 and main and it would be "in sync" again...

@brotkrueml
Copy link
Contributor

It's here:

https://github.com/TYPO3/typo3/blob/main/typo3/sysext/core/Classes/Html/RteHtmlParser.php#L51

However, then we would also have to adapt the link with the line number for every TYPO3-release, won't we? So maybe we better copy+paste it than to have people follow a link and need to check the whole github UI?

Luckily since 10.4 it didn't change, so we could just backport this PR down to 11.5, 12.4 and main and it would be "in sync" again...

Yup, I agree. We could just link to the file and mention the variable name, but inconvenient for the user.

@brotkrueml
Copy link
Contributor

@ErHaWeb Thanks for taking care and providing the PR 👍

@brotkrueml brotkrueml merged commit 38e5663 into TYPO3-Documentation:main Feb 29, 2024
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants