Skip to content

Commit

Permalink
[TASK] Mark properties as private in AdminModuleController (#283)
Browse files Browse the repository at this point in the history
As the class is defined as final, it does not make sense to set the properties as
protected as this class cannot be extended.

Releases: main, 12.4
  • Loading branch information
brotkrueml authored Aug 25, 2024
1 parent 1875c78 commit a1d9423
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Classes/Controller/AdminModuleController.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@
final readonly class AdminModuleController
{
public function __construct(
protected ModuleTemplateFactory $moduleTemplateFactory,
protected IconFactory $iconFactory,
private ModuleTemplateFactory $moduleTemplateFactory,
private IconFactory $iconFactory,
private UriBuilder $uriBuilder,
// ...
) {}
Expand Down

0 comments on commit a1d9423

Please sign in to comment.