[FEATURE] Provide detailed error messages for ext_emconf.php validation
#78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliashaeussler
force-pushed
the
feature/emconf-validation
branch
from
6e9ebd3
to
a55f966
Compare
|
Hi @o-ba, this branch is now also up to date. Would be great if you can take a look at this PR as well :) Cheers, Elias |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a more fine-grained way of
ext_emconf.phpfile validation. A newEmConfValidationErrorclass is introduced (can be converted to a native enum once support for PHP < 8.1 is dropped) which provides a set of possible validation errors. These errors are collected in a newEmConfVersionValidator::collectErrors()method and will be displayed inVersionServiceinstead of the previously used generic error message. This allows users to easily find and solve configuration mismatches inext_emconf.phpfile.Example: