JlrsCore has been released, so install a released version by default

Taaitaaiger · Apr 21, 2023 · 9b67d5b · 9b67d5b
1 parent c9d203d
commit 9b67d5b
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -146,7 +146,7 @@ jobs:
 
       - name: Run tests
         run: |
-          julia -e "import Pkg; Pkg.add(url=\"https://github.com/Taaitaaiger/JlrsCore.jl\")"
+          julia -e "import Pkg; Pkg.add(\"JlrsCore\")"
           export JULIA_DIR="$(dirname $(dirname $(which julia)))"
           export LD_LIBRARY_PATH="${JULIA_DIR}/lib:${JULIA_DIR}/lib/julia:${LD_LIBRARY_PATH}"
           cargo test --features full,julia-1-6 --verbose

diff --git a/jlrs/src/lib.rs b/jlrs/src/lib.rs
@@ -829,9 +829,9 @@ pub mod util;
 /// is used.
 #[derive(Clone)]
 pub enum InstallJlrsCore {
-    /// Install the current default revision of JlrsCore.jl
+    /// Install the most recent version of JlrsCore
     Default,
-    /// Don't install the JlrsCore package
+    /// Don't install the JlrsCore
     No,
     /// Install the given version
     Version {
@@ -861,7 +861,7 @@ impl InstallJlrsCore {
                          try
                              using JlrsCore
                          catch e
-                             import Pkg; Pkg.add(url=\"https://github.com/Taaitaaiger/JlrsCore.jl#c4710a4\")
+                             import Pkg; Pkg.add(\"JlrsCore\")
                              using JlrsCore
                          end
                      end",

diff --git a/jlrs/src/memory/context/ledger.rs b/jlrs/src/memory/context/ledger.rs
@@ -1,5 +1,5 @@
 // The ledger is used to track Julia data. It's implemented in a separate crate and distributed
-// as JlrsLedger_jll which is a dependency of JlrsCore.jl. The reason it works this way is because
+// as JlrsLedger_jll which is a dependency of JlrsCore. The reason it works this way is because
 // multiple packages could use different versions of jlrs and have been compiled with different
 // versions of Rust, all of these packages must use the same ledger.
 //

diff --git a/jlrs/src/runtime/builder.rs b/jlrs/src/runtime/builder.rs
@@ -131,9 +131,9 @@ cfg_if::cfg_if! {
                 self
             }
 
-            /// Enable or disable automatically installing JlrsCore.jl.
+            /// Enable or disable automatically installing JlrsCore.
             ///
-            /// In order to function correctly, jlrs requires that the JlrsCore.jl package is installed. By
+            /// In order to function correctly, jlrs requires that the JlrsCore package is installed. By
             /// default, this package is automatically installed if it hasn't been installed yet.
             pub fn install_jlrs(mut self, install: InstallJlrsCore) -> Self {
                 self.builder.install_jlrs_core = install;
@@ -258,9 +258,9 @@ impl RuntimeBuilder {
         self
     }
 
-    /// Enable or disable automatically installing JlrsCore.jl.
+    /// Enable or disable automatically installing JlrsCore.
     ///
-    /// In order to function correctly, jlrs requires that the JlrsCore.jl package is installed. By
+    /// In order to function correctly, jlrs requires that the JlrsCore package is installed. By
     /// default, this package is automatically installed if it hasn't been installed yet.
     pub fn install_jlrs(mut self, install: InstallJlrsCore) -> Self {
         self.install_jlrs_core = install;

diff --git a/julia_module_test/JuliaModuleTest.jl b/julia_module_test/JuliaModuleTest.jl
@@ -2,7 +2,7 @@ module JuliaModuleTestTests
 try
     using JlrsCore
 catch e
-    import Pkg; Pkg.add(url="https://github.com/Taaitaaiger/JlrsCore.jl")
+    import Pkg; Pkg.add("JlrsCore")
     using JlrsCore
 end