refactor: replace quinn with tokio_rustls #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkales
reviewed
Oct 17, 2024
fabian1409
force-pushed
the
refactor/mpc_net_tls_stream
branch
from
79fc52b to
e554837
Compare
dkales
reviewed
Oct 21, 2024
fabian1409
force-pushed
the
refactor/mpc_net_tls_stream
branch
4 times, most recently
from
e0e0f81 to
34e2b4f
Compare
fabian1409
force-pushed
the
refactor/mpc_net_tls_stream
branch
2 times, most recently
from
e400d11 to
e2710be
Compare
fabian1409
force-pushed
the
refactor/mpc_net_tls_stream
branch
from
e2710be to
b91f2cd
Compare
dkales
reviewed
Nov 26, 2024
| @@ -245,47 +247,27 @@ impl Rep3MpcNet { | |||
| let runtime = tokio::runtime::Builder::new_multi_thread() | |||
There was a problem hiding this comment.
do we want to limit the # of worker threads here to 2 or so?
…e 2 tls streams to avoid locks
…ync read/write wrapper, cleanup
fabian1409
force-pushed
the
refactor/mpc_net_tls_stream
branch
from
27c3d60 to
9ca3519
Compare
…te new channels in the background
fabian1409
force-pushed
the
refactor/mpc_net_tls_stream
branch
from
9ca3519 to
4bbf970
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.