Skip to content

Commit

Permalink
Merge pull request volcano-sh#1669 from gy95/install-golangci
Browse files Browse the repository at this point in the history
fix golangci-lint install
  • Loading branch information
volcano-sh-bot authored Aug 12, 2021
2 parents 7e8d545 + c838826 commit d60805f
Show file tree
Hide file tree
Showing 2 changed files with 56 additions and 2 deletions.
3 changes: 1 addition & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,7 @@ verify:
hack/verify-vendor-licenses.sh

lint: ## Lint the files
golangci-lint version
golangci-lint run -v
hack/verify-golangci-lint.sh

verify-generated-yaml:
./hack/check-generated-yaml.sh
Expand Down
55 changes: 55 additions & 0 deletions hack/verify-golangci-lint.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
#!/bin/bash

# Copyright 2014 The Kubernetes Authors.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

set -o errexit
set -o nounset
set -o pipefail

KUBE_ROOT=$(dirname "${BASH_SOURCE}")/..
GOPATH=$(go env GOPATH | awk -F ':' '{print $1}')

# check if golangci-lint installed
function check_golangci-lint() {
echo "checking whether golangci-lint has been installed"
command -v golangci-lint >/dev/null 2>&1
if [[ $? -ne 0 ]]; then
echo "installing golangci-lint ."
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.40.0
if [[ $? -ne 0 ]]; then
echo "golangci-lint installed failed, exiting."
exit 1
fi

export PATH=$PATH:$GOPATH/bin
else
echo "found golangci-lint"
fi
}

# run golangci-lint run to check codes
function golangci-lint_run() {
echo "begin run golangci-lint"
cd ${KUBE_ROOT}
golangci-lint run -v
}

set +e
check_golangci-lint
set -e

set +e
golangci-lint_run
set -e

0 comments on commit d60805f

Please sign in to comment.