October #2975
Open
October #2975
+607
−943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkbee1
requested changes
Oct 18, 2024
| @@ -1,4 +1,5 @@ | |||
| import 'package:altme/activity_log/activity_log.dart'; | |||
| import 'package:altme/app/app.dart'; | |||
There was a problem hiding this comment.
I don't think you need this import. I think I removed it from main while handling some chores
| @@ -324,7 +324,7 @@ abstract class ConstantsJson { | |||
| 'JsonWebSignature2020', | |||
| 'Ed25519Signature2018', | |||
| 'EcdsaSecp256k1Signature2019', | |||
| 'RsaSignature2018', | |||
There was a problem hiding this comment.
you should have a warning for this in vscode.
| Future<void> generateSSIAndCryptoAccount(List<String> mnemonic) async { | ||
| Future<void> generateSSIAndCryptoAccount({ | ||
| required List<String> mnemonic, | ||
| required bool restoreWallet, |
There was a problem hiding this comment.
wallet restoration is not the purpose of generateSSIAndCryptoAccount. It should be handled in separate process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change