Skip to content

Commit

Permalink
fix(TMC-28189): improve call to use in sass files + ts lint fix (#5287)
Browse files Browse the repository at this point in the history
  • Loading branch information
smouillour authored Apr 23, 2024
1 parent a10f800 commit f546896
Show file tree
Hide file tree
Showing 264 changed files with 284 additions and 267 deletions.
14 changes: 14 additions & 0 deletions .changeset/wet-eagles-grin.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
"@talend/json-schema-form-core": patch
"@talend/react-faceted-search": patch
"@talend/storybook-docs": patch
"@talend/design-system": patch
"@talend/design-docs": patch
"@talend/react-components": patch
"@talend/react-dataviz": patch
"@talend/react-stepper": patch
"@talend/react-forms": patch
"@talend/bootstrap-theme": patch
---

Fix: improve call of use in sass files + fix ts lint
4 changes: 2 additions & 2 deletions fork/json-schema-form-core/src/schema-defaults.ts
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ export function defaultForm(
ignore?: any,
globalOptions?: any,
) {
const form = [];
const form: any[] = [];
const lookup = {}; // Map path => form obj for fast lookup in merging
ignore = ignore || {};
globalOptions = globalOptions || {};
Expand All @@ -272,7 +272,7 @@ export function defaultForm(
Object.keys(schema.properties).forEach(key => {
if (ignore[key] !== true) {
const required = schema.required && schema.required.indexOf(key) !== -1;
const def = defaultFormDefinition(defaultSchemaTypes, key, schema.properties[key], {
const def: any = defaultFormDefinition(defaultSchemaTypes, key, schema.properties[key], {
path: [key], // Path to this property in bracket notation.
lookup: lookup, // Extra map to register with. Optimization for merger.
ignore: ignore, // The ignore list of paths (sans root level name)
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/ActionBar/ActionBar.module.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

$tc-action-bar-margin: $padding-small $padding-large $padding-small 0 !default;

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/ActionList/ActionList.module.scss
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;

@use '@talend/design-tokens/lib/_tokens.scss' as tokens;
@use '@talend/design-tokens/lib/_tokens' as tokens;

////
/// Action list
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

$tc-dropdown-loader-padding: $padding-small !default;
$tc-dropdown-button-right-padding: 0.5rem;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

$tc-icon-toggle-size: 1.5rem !default;
$tc-icon-toggle-icon-size: $svg-sm-size !default;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

.tc-app-switcher {
:global(.tc-svg-icon:first-child) {
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/Badge/Badge.module.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

$tc-badge-large-label-font-size: 0.875rem !default;
$tc-badge-large-label-font-weight: normal !default;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

// CircularProgress styles
$tc-circular-progress-light-fill: tokens.$coral-color-neutral-text-inverted !default;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

$tc-collapsible-panel-padding-smaller: $padding-smaller !default;
$tc-collapsible-panel-padding-normal: $padding-normal !default;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

.tc-length-badge {
background-color: tokens.$coral-color-neutral-background-medium;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

:global(.tc-model .tc-tree) {
overflow: auto;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

$default-height: 2.5rem !default;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

.tc-tree-branch-icon {
display: flex;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;
@import '~@talend/bootstrap-theme/src/theme/animation';

$model-node-height: 1.875rem !default;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* stylelint-disable declaration-no-important */
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

$hightlight-height: 1.375rem !default;
$records-node-height: $hightlight-height !default;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

.tc-simple-text {
display: flex;
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/DataViewer/theme.module.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

$tc-layout-skeleton-width: 6rem !default;
$tc-layout-skeleton-height: 6rem !default;
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/Datalist/Datalist.module.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

$tc-datalist-items-max-height: 20rem !default;
$tc-datalist-item-height: 2.5rem !default;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

@import '../shared/styles/mixins';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;
@import '../shared/styles/mixins';

$tc-timepicker-width: 5rem !default;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

.validation {
display: flex;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

$tc-datetimepicker-width: 19.375rem !default;
$tc-datetimepicker-box-shadow: 0 0.0625rem 0.1875rem 0 rgba(0, 0, 0, 0.2) !default;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

@import '../../shared/styles/mixins';
@import '../../shared/styles/variables';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

@import '../../shared/styles/mixins';
@import '../../shared/styles/variables';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

@import '../../shared/styles/mixins';
@import '../../shared/styles/variables';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* stylelint-disable color-hex-case */
/* stylelint-disable selector-no-qualifying-type */
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

@import '../../shared/styles/mixins';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

@mixin nav-action {
padding: 0;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

$border-default: 0.0625rem solid tokens.$coral-color-neutral-border !default;
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;
@import '../../shared/styles/mixins';

.common {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

.container {
color: tokens.$coral-color-neutral-text-weak;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

@import '../../shared/styles/mixins';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

@import '../../shared/styles/mixins';
@import '../../shared/styles/variables';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

.container {
padding: tokens.$coral-spacing-xxs 0;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

@import './variables';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

$border-default: 0.0625rem solid tokens.$coral-color-neutral-border !default;
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

.common {
display: flex;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

.container {
height: 100%;
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/Dialog/Dialog.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

:global {
.modal-flex .modal-body {
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/Drawer/Drawer.module.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

$tc-drawer-bgcolor: tokens.$coral-color-neutral-background !default;
$tc-drawer-padding: tokens.$coral-spacing-m !default;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;
@import '~@talend/bootstrap-theme/src/theme/animation';

$tc-icon-editable-text-size: 0.5rem !default;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

@mixin ellipsis {
white-space: nowrap;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

$tc-enumeration-height: 50vh !default;
$tc-enumeration-font-size: 0.875rem !default;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

$tc-enumeration-smaller-padding: $padding-smaller !default;
$tc-enumeration-small-padding: $padding-small !default;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* stylelint-disable color-hex-case */
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

$tc-enumeration-normal-padding: $padding-normal !default;
$tc-enumeration-smaller-padding: $padding-smaller !default;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

$tc-enumeration-height: 40vh !default;

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/FilterBar/FilterBar.module.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

// Filter styles
$tc-filter-bar-width: 250px !default;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

$svg-tab-width: 1.625rem !default;
$svg-other-characters: 0.1875rem !default;
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/GridLayout/Grid.module.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

.layout {
:global(.react-grid-item) {
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/GuidedTour/GuidedTour.module.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

$tc-guidedtour-accent-color: tokens.$coral-color-accent-text !default;
$tc-guidedtour-tooltip-padding: $padding-large !default;
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/HeaderBar/HeaderBar.module.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

$tc-headerbar-logo-width: tokens.$coral-sizing-s !default;
$tc-headerbar-logo-full-width: 5.3125rem !default;
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/HttpError/HttpError.module.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

.http-error {
position: relative;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* stylelint-disable selector-no-qualifying-type */
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

.json-schema-renderer {
margin-top: $padding-large;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

.tc-skip-links {
position: absolute;
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/List/List.module.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '@talend/bootstrap-theme/src/theme/guidelines' as *;
@use '@talend/design-tokens/lib/tokens';
@use '@talend/design-tokens/lib/tokens' as tokens;

// List styles

Expand Down
Loading

0 comments on commit f546896

Please sign in to comment.