chore: changed skeleton "sized" variant props type #5159

dlcaldeira · 2024-02-02T11:16:29Z

What is the problem this PR is trying to solve?
The skeleton "sized" variant only allowed for fixed values for the width and height props

What is the chosen solution to this problem?
Changed the width and height props from number to string so it can height receive fixed or dynamic values

Please check if the PR fulfills these requirements

The PR have used yarn changeset to a request a release from the CI if wanted.
The PR commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features) And non reg done before need review
Docs have been added / updated (for bug fixes / features)
Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

…ings

github-actions · 2024-02-02T11:25:59Z

5159

Demo is available here

github-actions · 2024-02-02T11:28:21Z

Title	Statements	Branches	Functions
assets-api	28.4% (25/88)	30.76% (16/52)	21.42% (3/14)
cmf	89.2% (1272/1426)	80.36% (618/769)	88.91% (361/406)
cmf-cqrs	87.43% (160/183)	70.23% (59/84)	84.21% (48/57)
cmf-router	69.23% (135/195)	55.71% (78/140)	56.81% (25/44)
components	90.78% (5596/6164)	81.88% (3242/3959)	88.29% (1410/1597)
containers	83.71% (1388/1658)	74.81% (692/925)	75.17% (327/435)
dataviz	85.6% (321/375)	66.66% (160/240)	75.64% (118/156)
design-system	65.07% (902/1386)	47.43% (454/957)	52.16% (193/370)
faceted-search	85.75% (680/793)	79.15% (300/379)	82.75% (240/290)
flow-designer	70.07% (651/929)	66.72% (355/532)	70.92% (200/282)
forms	85.83% (1679/1956)	75.37% (915/1214)	84.58% (472/558)
http	100% (85/85)	98.07% (51/52)	100% (34/34)
sagas	92.3% (24/26)	66.66% (4/6)	50% (2/4)
stepper	81.52% (150/184)	59.34% (54/91)	80.85% (38/47)
utils	100% (70/70)	90.9% (10/11)	100% (22/22)

github-actions · 2024-02-02T11:31:30Z

Size Change: -65 B (0%)

Total Size: 16.8 MB

ℹ️ View Unchanged

Filename	Size	Change
`./packages/assets-api/dist/TalendAssetsApi.js`	7.15 kB	0 B
`./packages/assets-api/dist/TalendAssetsApi.js.dependencies.json`	2 B	0 B
`./packages/assets-api/dist/TalendAssetsApi.min.js`	3.33 kB	0 B
`./packages/assets-api/dist/TalendAssetsApi.min.js.dependencies.json`	2 B	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js`	184 kB	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json`	672 B	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js`	39.4 kB	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json`	695 B	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.js`	163 kB	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json`	1.25 kB	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js`	12.8 kB	0 B
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json`	1.29 kB	0 B
`./packages/cmf/dist/TalendReactCmf.js`	714 kB	0 B
`./packages/cmf/dist/TalendReactCmf.js.dependencies.json`	1.31 kB	0 B
`./packages/cmf/dist/TalendReactCmf.min.js`	137 kB	0 B
`./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json`	1.35 kB	0 B
`./packages/components/dist/TalendReactComponents.css`	408 kB	0 B
`./packages/components/dist/TalendReactComponents.js`	4.78 MB	0 B
`./packages/components/dist/TalendReactComponents.js.dependencies.json`	3.21 kB	0 B
`./packages/components/dist/TalendReactComponents.min.css`	215 kB	0 B
`./packages/components/dist/TalendReactComponents.min.js`	1.29 MB	0 B
`./packages/components/dist/TalendReactComponents.min.js.dependencies.json`	3.29 kB	0 B
`./packages/containers/dist/TalendReactContainers.css`	2.99 kB	0 B
`./packages/containers/dist/TalendReactContainers.js`	614 kB	0 B
`./packages/containers/dist/TalendReactContainers.js.dependencies.json`	1.4 kB	0 B
`./packages/containers/dist/TalendReactContainers.min.css`	1.78 kB	0 B
`./packages/containers/dist/TalendReactContainers.min.js`	122 kB	0 B
`./packages/containers/dist/TalendReactContainers.min.js.dependencies.json`	1.45 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.css`	28.1 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.js`	370 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json`	1.15 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.min.css`	12.2 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.min.js`	59.9 kB	0 B
`./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json`	1.18 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.css`	316 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.js`	1.3 MB	-59 B (0%)
`./packages/design-system/dist/TalendDesignSystem.js.dependencies.json`	1.57 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.min.css`	200 kB	0 B
`./packages/design-system/dist/TalendDesignSystem.min.js`	263 kB	-6 B (0%)
`./packages/design-system/dist/TalendDesignSystem.min.js.dependencies.json`	1.61 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.css`	67.6 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.js`	39.7 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.js.dependencies.json`	2 B	0 B
`./packages/design-tokens/dist/TalendDesignTokens.min.css`	63.4 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.min.js`	33.4 kB	0 B
`./packages/design-tokens/dist/TalendDesignTokens.min.js.dependencies.json`	2 B	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.css`	19.2 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.js`	657 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.js.dependencies.json`	1.36 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.css`	6.41 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js`	134 kB	0 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js.dependencies.json`	1.4 kB	0 B
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js`	50.8 kB	0 B
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js.dependencies.json`	1.25 kB	0 B
`./packages/forms/dist/TalendReactForms.css`	37.3 kB	0 B
`./packages/forms/dist/TalendReactForms.js`	850 kB	0 B
`./packages/forms/dist/TalendReactForms.js.dependencies.json`	1.35 kB	0 B
`./packages/forms/dist/TalendReactForms.min.css`	12.5 kB	0 B
`./packages/forms/dist/TalendReactForms.min.js`	221 kB	0 B
`./packages/forms/dist/TalendReactForms.min.js.dependencies.json`	1.39 kB	0 B
`./packages/http/dist/TalendHttp.js`	24.8 kB	0 B
`./packages/http/dist/TalendHttp.js.dependencies.json`	2 B	0 B
`./packages/http/dist/TalendHttp.min.js`	5.31 kB	0 B
`./packages/http/dist/TalendHttp.min.js.dependencies.json`	2 B	0 B
`./packages/icons/dist/bundle.js`	1.26 kB	0 B
`./packages/icons/dist/info.js`	26.8 kB	0 B
`./packages/icons/dist/react.esm.js`	614 kB	0 B
`./packages/icons/dist/react.js`	654 kB	0 B
`./packages/icons/dist/talend-icons-webfont.css`	18.3 kB	0 B
`./packages/icons/dist/talendicons.css`	334 B	0 B
`./packages/icons/dist/TalendIcons.js`	786 kB	0 B
`./packages/icons/dist/TalendIcons.js.dependencies.json`	128 B	0 B
`./packages/icons/dist/TalendIcons.min.js`	636 kB	0 B
`./packages/icons/dist/TalendIcons.min.js.dependencies.json`	131 B	0 B
`./packages/icons/dist/typeUtils.js`	14.5 kB	0 B
`./packages/jsfc/dist/index.js`	86.3 kB	0 B
`./packages/jsfc/dist/index.js.dependencies.json`	2 B	0 B
`./packages/router-bridge/dist/TalendRouterBridge.js`	134 kB	0 B
`./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json`	1.05 kB	0 B
`./packages/router-bridge/dist/TalendRouterBridge.min.js`	21 kB	0 B
`./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json`	1.07 kB	0 B
`./packages/sagas/dist/TalendReactSagas.js`	10.9 kB	0 B
`./packages/sagas/dist/TalendReactSagas.js.dependencies.json`	348 B	0 B
`./packages/sagas/dist/TalendReactSagas.min.js`	1.41 kB	0 B
`./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json`	360 B	0 B
`./packages/stepper/dist/TalendReactStepper.css`	2.41 kB	0 B
`./packages/stepper/dist/TalendReactStepper.js`	97 kB	0 B
`./packages/stepper/dist/TalendReactStepper.js.dependencies.json`	1.27 kB	0 B
`./packages/stepper/dist/TalendReactStepper.min.css`	1.2 kB	0 B
`./packages/stepper/dist/TalendReactStepper.min.js`	9.38 kB	0 B
`./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json`	1.31 kB	0 B
`./packages/storybook-docs/dist/globalStyles.js`	0 B	0 B	🆕
`./packages/storybook-docs/dist/globalStyles.min.css`	384 B	0 B
`./packages/storybook-docs/dist/managerStyles.js`	0 B	0 B	🆕
`./packages/storybook-docs/dist/managerStyles.min.css`	1.5 kB	0 B
`./packages/theme/dist/bootstrap.css`	171 kB	0 B
`./packages/theme/dist/bootstrap.js`	2.51 kB	0 B
`./packages/theme/dist/bootstrap.js.dependencies.json`	3 B	0 B

_{compressed-size-action}

chore: changed skeleton "sized" variant width and height props to str…

6340ed4

…ings

dlcaldeira added the need review label Feb 2, 2024

dlcaldeira self-assigned this Feb 2, 2024

dlcaldeira temporarily deployed to pull_request_unsafe February 2, 2024 11:16 — with GitHub Actions Inactive

romainseb approved these changes Feb 2, 2024

View reviewed changes

romainseb merged commit bb4db90 into master Feb 2, 2024
14 checks passed

romainseb deleted the dcaldeira/chore/skeleton-props branch February 2, 2024 11:36

romainseb had a problem deploying to pull_request_unsafe February 2, 2024 11:36 — with GitHub Actions Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: changed skeleton "sized" variant props type #5159

chore: changed skeleton "sized" variant props type #5159

dlcaldeira commented Feb 2, 2024 •

edited

Loading

github-actions bot commented Feb 2, 2024

github-actions bot commented Feb 2, 2024

github-actions bot commented Feb 2, 2024

chore: changed skeleton "sized" variant props type #5159

chore: changed skeleton "sized" variant props type #5159

Conversation

dlcaldeira commented Feb 2, 2024 • edited Loading

github-actions bot commented Feb 2, 2024

github-actions bot commented Feb 2, 2024

github-actions bot commented Feb 2, 2024

dlcaldeira commented Feb 2, 2024 •

edited

Loading