feat(DGT-342): Coral Quality Bars #5259

dlcaldeira · 2024-04-08T14:25:52Z

What is the problem this PR is trying to solve?
Zenith project needs to access the Quality Bar components

What is the chosen solution to this problem?
Move the Quality Bar and RatioBar components to the design-system so it can be access from Talend and Qlik project

Please check if the PR fulfills these requirements

The PR have used yarn changeset to a request a release from the CI if wanted.
The PR commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features) And non reg done before need review
Docs have been added / updated (for bug fixes / features)
Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

github-actions · 2024-04-08T14:33:16Z

5259

Demo is available here

github-actions · 2024-04-08T14:38:13Z

Title	Statements	Branches	Functions
assets-api	28.4% (25/88)	30.76% (16/52)	21.42% (3/14)
cmf	89.2% (1272/1426)	80.36% (618/769)	88.91% (361/406)
cmf-cqrs	87.43% (160/183)	70.23% (59/84)	84.21% (48/57)
cmf-router	69.23% (135/195)	55.71% (78/140)	56.81% (25/44)
components	90.8% (5513/6071)	81.82% (3188/3896)	88.19% (1390/1576)
containers	83.71% (1388/1658)	74.81% (692/925)	75.17% (327/435)
dataviz	85.44% (323/378)	66.66% (160/240)	75.79% (119/157)
design-system	66.88% (1002/1498)	50.38% (527/1046)	54.54% (216/396)
faceted-search	85.69% (677/790)	79.31% (303/382)	82.63% (238/288)
flow-designer	70.07% (651/929)	66.72% (355/532)	70.92% (200/282)
forms	85.4% (1627/1905)	75.53% (920/1218)	84.22% (459/545)
http	100% (85/85)	98.07% (51/52)	100% (34/34)
sagas	92.3% (24/26)	66.66% (4/6)	50% (2/4)
stepper	81.52% (150/184)	59.34% (54/91)	80.85% (38/47)
utils	100% (73/73)	90.9% (10/11)	100% (24/24)

github-actions · 2024-04-08T14:40:35Z

Size Change: +7.08 kB (0%)

Total Size: 17.5 MB

Filename	Size	Change
`./packages/components/dist/TalendReactComponents.css`	397 kB	-4.98 kB (-1%)
`./packages/components/dist/TalendReactComponents.js`	4.85 MB	-26.7 kB (-1%)
`./packages/components/dist/TalendReactComponents.min.css`	212 kB	-2.53 kB (-1%)
`./packages/components/dist/TalendReactComponents.min.js`	1.29 MB	-6.06 kB (0%)
`./packages/design-system/dist/TalendDesignSystem.css`	321 kB	+5.04 kB (+2%)
`./packages/design-system/dist/TalendDesignSystem.js`	1.43 MB	+33.4 kB (+2%)
`./packages/design-system/dist/TalendDesignSystem.min.css`	203 kB	+2.53 kB (+1%)
`./packages/design-system/dist/TalendDesignSystem.min.js`	288 kB	+6.38 kB (+2%)

ℹ️ View Unchanged

Filename	Size
`./packages/assets-api/dist/TalendAssetsApi.js`	7.15 kB
`./packages/assets-api/dist/TalendAssetsApi.js.dependencies.json`	2 B
`./packages/assets-api/dist/TalendAssetsApi.min.js`	3.33 kB
`./packages/assets-api/dist/TalendAssetsApi.min.js.dependencies.json`	2 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js`	277 kB
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json`	595 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js`	54.6 kB
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json`	614 B
`./packages/cmf-router/dist/TalendReactCmfRouter.js`	163 kB
`./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json`	1.25 kB
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js`	12.8 kB
`./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json`	1.29 kB
`./packages/cmf/dist/TalendReactCmf.js`	806 kB
`./packages/cmf/dist/TalendReactCmf.js.dependencies.json`	1.31 kB
`./packages/cmf/dist/TalendReactCmf.min.js`	151 kB
`./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json`	1.35 kB
`./packages/components/dist/TalendReactComponents.js.dependencies.json`	3.21 kB
`./packages/components/dist/TalendReactComponents.min.js.dependencies.json`	3.29 kB
`./packages/containers/dist/TalendReactContainers.css`	2.99 kB
`./packages/containers/dist/TalendReactContainers.js`	706 kB
`./packages/containers/dist/TalendReactContainers.js.dependencies.json`	1.4 kB
`./packages/containers/dist/TalendReactContainers.min.css`	1.78 kB
`./packages/containers/dist/TalendReactContainers.min.js`	136 kB
`./packages/containers/dist/TalendReactContainers.min.js.dependencies.json`	1.45 kB
`./packages/dataviz/dist/TalendReactDataviz.css`	28.1 kB
`./packages/dataviz/dist/TalendReactDataviz.js`	370 kB
`./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json`	1.15 kB
`./packages/dataviz/dist/TalendReactDataviz.min.css`	12.2 kB
`./packages/dataviz/dist/TalendReactDataviz.min.js`	59.5 kB
`./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json`	1.19 kB
`./packages/design-system/dist/TalendDesignSystem.js.dependencies.json`	1.49 kB
`./packages/design-system/dist/TalendDesignSystem.min.js.dependencies.json`	1.53 kB
`./packages/design-tokens/dist/TalendDesignTokens.css`	67.6 kB
`./packages/design-tokens/dist/TalendDesignTokens.js`	39.7 kB
`./packages/design-tokens/dist/TalendDesignTokens.js.dependencies.json`	2 B
`./packages/design-tokens/dist/TalendDesignTokens.min.css`	63.4 kB
`./packages/design-tokens/dist/TalendDesignTokens.min.js`	33.4 kB
`./packages/design-tokens/dist/TalendDesignTokens.min.js.dependencies.json`	2 B
`./packages/faceted-search/dist/TalendReactFacetedSearch.css`	19.1 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.js`	751 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.js.dependencies.json`	1.54 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.css`	6.28 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js`	148 kB
`./packages/faceted-search/dist/TalendReactFacetedSearch.min.js.dependencies.json`	1.59 kB
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js`	50.7 kB
`./packages/flow-designer/dist/TalendReactFlowDesigner.min.js.dependencies.json`	1.25 kB
`./packages/forms/dist/TalendReactForms.css`	19.7 kB
`./packages/forms/dist/TalendReactForms.js`	902 kB
`./packages/forms/dist/TalendReactForms.js.dependencies.json`	1.36 kB
`./packages/forms/dist/TalendReactForms.min.css`	6.13 kB
`./packages/forms/dist/TalendReactForms.min.js`	228 kB
`./packages/forms/dist/TalendReactForms.min.js.dependencies.json`	1.39 kB
`./packages/http/dist/TalendHttp.js`	24.8 kB
`./packages/http/dist/TalendHttp.js.dependencies.json`	2 B
`./packages/http/dist/TalendHttp.min.js`	5.31 kB
`./packages/http/dist/TalendHttp.min.js.dependencies.json`	2 B
`./packages/icons/dist/bundle.js`	1.26 kB
`./packages/icons/dist/info.js`	26.8 kB
`./packages/icons/dist/react.esm.js`	614 kB
`./packages/icons/dist/react.js`	654 kB
`./packages/icons/dist/talend-icons-webfont.css`	18.3 kB
`./packages/icons/dist/talendicons.css`	334 B
`./packages/icons/dist/TalendIcons.js`	786 kB
`./packages/icons/dist/TalendIcons.js.dependencies.json`	128 B
`./packages/icons/dist/TalendIcons.min.js`	636 kB
`./packages/icons/dist/TalendIcons.min.js.dependencies.json`	131 B
`./packages/icons/dist/typeUtils.js`	14.5 kB
`./packages/jsfc/dist/index.js`	86.3 kB
`./packages/jsfc/dist/index.js.dependencies.json`	2 B
`./packages/router-bridge/dist/TalendRouterBridge.js`	134 kB
`./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json`	1.05 kB
`./packages/router-bridge/dist/TalendRouterBridge.min.js`	21 kB
`./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json`	1.07 kB
`./packages/sagas/dist/TalendReactSagas.js`	10.9 kB
`./packages/sagas/dist/TalendReactSagas.js.dependencies.json`	348 B
`./packages/sagas/dist/TalendReactSagas.min.js`	1.41 kB
`./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json`	360 B
`./packages/stepper/dist/TalendReactStepper.css`	2.41 kB
`./packages/stepper/dist/TalendReactStepper.js`	97 kB
`./packages/stepper/dist/TalendReactStepper.js.dependencies.json`	1.27 kB
`./packages/stepper/dist/TalendReactStepper.min.css`	1.2 kB
`./packages/stepper/dist/TalendReactStepper.min.js`	9.37 kB
`./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json`	1.31 kB
`./packages/storybook-docs/dist/globalStyles.js`	0 B	🆕
`./packages/storybook-docs/dist/globalStyles.min.css`	384 B
`./packages/storybook-docs/dist/managerStyles.js`	0 B	🆕
`./packages/storybook-docs/dist/managerStyles.min.css`	1.5 kB
`./packages/theme/dist/bootstrap.css`	171 kB
`./packages/theme/dist/bootstrap.js`	2.51 kB
`./packages/theme/dist/bootstrap.js.dependencies.json`	3 B

_{compressed-size-action}

… to use the ones from DS

…alend/ui into dcaldeira/feature/DGT-342-quality-bars # Conflicts: # packages/components/src/QualityBar/QualityBar.component.tsx # packages/design-system/src/components/Accordion/Primitive/CollapsiblePanelHeader.tsx

romainseb · 2024-04-11T08:41:03Z

packages/design-system/src/components/QualityBar/QualityBar.component.test.tsx

@@ -1,4 +1,6 @@
+import { describe, expect, it } from '@jest/globals';


Do we need them ?

feat(DGT-342): Coral Quality Bars

d6c13ba

dlcaldeira temporarily deployed to pull_request_unsafe April 8, 2024 14:25 — with GitHub Actions Inactive

dlcaldeira marked this pull request as draft April 8, 2024 14:26

Fixed RatioBar not applicable translation

7103c0b

dlcaldeira temporarily deployed to pull_request_unsafe April 9, 2024 08:50 — with GitHub Actions Inactive

fix test

5464a75

dlcaldeira temporarily deployed to pull_request_unsafe April 9, 2024 13:05 — with GitHub Actions Inactive

dlcaldeira self-assigned this Apr 9, 2024

dlcaldeira marked this pull request as ready for review April 9, 2024 13:14

add changeset

90674bc

dlcaldeira temporarily deployed to pull_request_unsafe April 9, 2024 13:23 — with GitHub Actions Inactive

removed QualityBar and RatioBar componets on @talend-react-components…

19e188f

… to use the ones from DS

dlcaldeira temporarily deployed to pull_request_unsafe April 10, 2024 07:58 — with GitHub Actions Inactive

dlcaldeira had a problem deploying to pull_request_unsafe April 10, 2024 07:58 — with GitHub Actions Error

romainseb temporarily deployed to pull_request_unsafe April 10, 2024 13:33 — with GitHub Actions Inactive

dlcaldeira added 2 commits April 10, 2024 16:10

fix ci

327ce23

dlcaldeira temporarily deployed to pull_request_unsafe April 10, 2024 16:10 — with GitHub Actions Inactive

remove duplicated prop

69dda3e

dlcaldeira temporarily deployed to pull_request_unsafe April 10, 2024 17:00 — with GitHub Actions Inactive

Update changeset

acf926d

dlcaldeira temporarily deployed to pull_request_unsafe April 11, 2024 08:15 — with GitHub Actions Inactive

dlcaldeira had a problem deploying to pull_request_unsafe April 11, 2024 08:15 — with GitHub Actions Error

Fixed PR

4e1fe7a

dlcaldeira temporarily deployed to pull_request_unsafe April 11, 2024 08:23 — with GitHub Actions Inactive

dlcaldeira temporarily deployed to pull_request_unsafe April 11, 2024 08:24 — with GitHub Actions Inactive

romainseb approved these changes Apr 11, 2024

View reviewed changes

mhuchet approved these changes Apr 11, 2024

View reviewed changes

dlcaldeira merged commit 8bf0dd5 into master Apr 11, 2024
12 checks passed

dlcaldeira deleted the dcaldeira/feature/DGT-342-quality-bars branch April 11, 2024 09:49

dlcaldeira had a problem deploying to pull_request_unsafe April 11, 2024 09:49 — with GitHub Actions Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(DGT-342): Coral Quality Bars #5259

feat(DGT-342): Coral Quality Bars #5259

dlcaldeira commented Apr 8, 2024 •

edited

Loading

github-actions bot commented Apr 8, 2024

github-actions bot commented Apr 8, 2024 •

edited

Loading

github-actions bot commented Apr 8, 2024 •

edited

Loading

romainseb Apr 11, 2024

		@@ -1,4 +1,6 @@
		import { describe, expect, it } from '@jest/globals';

feat(DGT-342): Coral Quality Bars #5259

feat(DGT-342): Coral Quality Bars #5259

Conversation

dlcaldeira commented Apr 8, 2024 • edited Loading

github-actions bot commented Apr 8, 2024

github-actions bot commented Apr 8, 2024 • edited Loading

github-actions bot commented Apr 8, 2024 • edited Loading

romainseb Apr 11, 2024

Choose a reason for hiding this comment

dlcaldeira commented Apr 8, 2024 •

edited

Loading

github-actions bot commented Apr 8, 2024 •

edited

Loading

github-actions bot commented Apr 8, 2024 •

edited

Loading