fix: history search by hash

always defaulting to current selected account make search by hash impossible
TalismanSociety · Dec 16, 2023 · cc72990 · cc72990
1 parent 7394360
commit cc72990
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/apps/web/src/components/widgets/history/History.tsx b/apps/web/src/components/widgets/history/History.tsx
@@ -30,7 +30,7 @@ type HistoryProps = {
 }
 
 // TODO: lots of repetitive account look up using `encodeAnyAddress`
-const InnerHistory = (props: HistoryProps) => {
+const _History = (props: HistoryProps) => {
   const allAccounts = useRecoilValue(accountsState)
 
   const [items, setItems] = useState<ExtrinsicNode[]>([])
@@ -316,13 +316,16 @@ const InnerHistory = (props: HistoryProps) => {
 }
 
 const History = (props: HistoryProps) => {
-  const selectedAccounts = useRecoilValue(selectedAccountsState)
-  const accountsToSearch = props.accounts ?? selectedAccounts
-
   // To invalidate component after query changes
-  const key = useMemo(() => JSON.stringify({ ...props, accounts: accountsToSearch }), [accountsToSearch, props])
+  const key = useMemo(() => JSON.stringify(props), [props])
 
-  return <InnerHistory key={key} {...props} accounts={accountsToSearch} />
+  return <_History key={key} {...props} />
 }
 
 export default History
+
+export const SelectedAccountsHistory = (props: Omit<HistoryProps, 'accounts'>) => {
+  const accountsToSearch = useRecoilValue(selectedAccountsState)
+
+  return <History {...props} accounts={accountsToSearch} />
+}
diff --git a/apps/web/src/routes/portfolio/overview.tsx b/apps/web/src/routes/portfolio/overview.tsx
@@ -6,7 +6,7 @@ import Asset, { AssetsList, AssetsListLocked } from '@components/recipes/Asset'
 import AnimatedFiatNumber from '@components/widgets/AnimatedFiatNumber'
 import ErrorBoundary from '@components/widgets/ErrorBoundary'
 import PortfolioAllocationGraph from '@components/widgets/PortfolioAllocationGraph'
-import History from '@components/widgets/history/History'
+import { SelectedAccountsHistory } from '@components/widgets/history/History'
 import Stakes from '@components/widgets/staking/Stakes'
 import { Eye, EyeOff } from '@talismn/icons'
 import { Button, IconButton } from '@talismn/ui'
@@ -111,9 +111,9 @@ const AssetsOverview = () => {
 }
 
 const HistoryOverview = () => (
-  <div css>
+  <div>
     <SectionHeader headlineText="History" />
-    <History maxCount={8} />
+    <SelectedAccountsHistory maxCount={8} />
     <div css={{ display: 'flex' }}>
       <Button variant="secondary" as={Link} to="history" css={{ marginTop: '1.8rem', marginLeft: 'auto' }}>
         View all history