Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: errors in balance pool #1788

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Conversation

0xKheops
Copy link
Contributor

Fixes a bunch of sentry errors about isActiveToken/isActiveEvmNetwork/isActiveChain being sometimes called from pool.ts with a null argument, that i can't reproduce on my computer.

Also includes a fix to an unawaited promise in chaindata providers, that could be tied to the above problem

@0xKheops 0xKheops requested review from alecdwm and chidg January 21, 2025 09:27
Copy link
Contributor

github-actions bot commented Jan 21, 2025

🦋 Changeset(s) detected

This PR includes changeset(s) for the following changed packages:

"@talismn/chaindata-provider"

Not sure what this means? Click here to learn what changesets are.

Copy link
Member

@alecdwm alecdwm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@0xKheops 0xKheops merged commit d20764a into dev Jan 22, 2025
6 checks passed
@0xKheops 0xKheops deleted the fix/unawaited-promise-in-chaindata-provider branch January 22, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants