Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: class style model #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Baoyx007
Copy link

feat: #8

@wxnet2013
Copy link
Member

多谢你的关注和 PR,修改的内容有点多,我花一些时间研究下你的代码。
另外,我在另外一个仓库里也实现了这个特性:rxloop-class-model
这里有个问题是,我在思考这个特性要不要合并到 Core 里面,欢迎意见~

"@babel/plugin-proposal-object-rest-spread": "^7.0.0",
"@babel/preset-env": "^7.0.0",
"@babel/preset-flow": "^7.0.0",
"@babel/register": "^7.0.0",
"@rxloop/immer": "^0.1.5",
"@rxloop/loading": "^0.2.2",
"babel-core": "^7.0.0-beta.3",
"babel-core": "^7.0.0-bridge.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7.0.0-bridge.0 是 beta.3 的上一个版本,这里降低版本的原因是什么呢?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好像在我的 vscode 里 debug 有问题, 而且我看 https://jestjs.io/docs/en/getting-started#using-babel这样设置的.

放在单独的 package 也挺好, 毕竟不是每个人都需要这个 decorator. 但我觉得可以用 lerna 管理多个包, 放在同一个仓库里.

Copy link
Member

@wxnet2013 wxnet2013 Jan 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目前主要精力在 1.x ,验证方案和场景的匹配度,之后 2.x 会用 TS 重写并用 lerna 管理这些分散的 npm 包。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants