Fix Svelte Adapter (#5762)

* fix svelte adapter and update examples * fix svelte adapter and update examples * remove console logs --------- Co-authored-by: Kevin Van Cott <[email protected]>
TanStack · Sep 27, 2024 · ccb937d · ccb937d
1 parent f1ba2f4
commit ccb937d
Show file tree

Hide file tree

Showing 18 changed files with 5,666 additions and 2,344 deletions.
diff --git a/examples/svelte/basic/package.json b/examples/svelte/basic/package.json
@@ -15,7 +15,7 @@
     "@sveltejs/vite-plugin-svelte": "^4.0.0-next",
     "@tanstack/svelte-table": "^9.0.0-alpha.10",
     "@tsconfig/svelte": "^5.0.4",
-    "svelte": "^5.0.0-next",
+    "svelte": "^5.0.0-next.260",
     "svelte-check": "^3.8.4",
     "typescript": "5.4.5",
     "vite": "^5.3.2"

diff --git a/examples/svelte/column-groups/package.json b/examples/svelte/column-groups/package.json
@@ -15,7 +15,7 @@
     "@sveltejs/vite-plugin-svelte": "^4.0.0-next",
     "@tanstack/svelte-table": "^9.0.0-alpha.10",
     "@tsconfig/svelte": "^5.0.4",
-    "svelte": "^5.0.0-next",
+    "svelte": "5.0.0-next.260",
     "svelte-check": "^3.8.4",
     "typescript": "5.4.5",
     "vite": "^5.3.2"

diff --git a/examples/svelte/column-groups/src/App.svelte b/examples/svelte/column-groups/src/App.svelte
@@ -4,6 +4,7 @@
     FlexRender,
     createCoreRowModel,
     createTable,
+    tableFeatures,
     tableOptions,
   } from '@tanstack/svelte-table'
   import './index.css'
@@ -44,7 +45,9 @@
     },
   ]
 
-  const defaultColumns: ColumnDef<any, Person>[] = [
+  const _features = tableFeatures({})
+
+  const defaultColumns: ColumnDef<typeof _features, Person>[] = [
     {
       header: 'Name',
       footer: (props) => props.column.id,
@@ -97,9 +100,10 @@
   ]
 
   const options = tableOptions({
+    _features,
+    _rowModels: {},
     data: defaultData,
     columns: defaultColumns,
-    getCoreRowModel: createCoreRowModel(),
   })
 
   const table = createTable(options)
@@ -126,7 +130,7 @@
     <tbody>
       {#each table.getRowModel().rows as row}
         <tr>
-          {#each row.getVisibleCells() as cell}
+          {#each row.getAllCells() as cell}
             <td>
               <FlexRender
                 content={cell.column.columnDef.cell}

diff --git a/examples/svelte/column-ordering/package.json b/examples/svelte/column-ordering/package.json
@@ -16,7 +16,7 @@
     "@sveltejs/vite-plugin-svelte": "^4.0.0-next",
     "@tanstack/svelte-table": "^9.0.0-alpha.10",
     "@tsconfig/svelte": "^5.0.4",
-    "svelte": "^5.0.0-next",
+    "svelte": "5.0.0-next.260",
     "svelte-check": "^3.8.4",
     "typescript": "5.4.5",
     "vite": "^5.3.2"

diff --git a/examples/svelte/column-ordering/src/App.svelte b/examples/svelte/column-ordering/src/App.svelte
@@ -3,20 +3,25 @@
   import type {
     ColumnDef,
     ColumnOrderState,
-    OnChangeFn,
-    TableOptions,
     ColumnVisibilityState,
+    TableOptions,
   } from '@tanstack/svelte-table'
   import {
+    ColumnOrdering,
+    ColumnVisibility,
     FlexRender,
-    createCoreRowModel,
-    createSortedRowModel,
     createTable,
+    tableFeatures,
   } from '@tanstack/svelte-table'
   import './index.css'
   import { makeData, type Person } from './makeData'
   import { createTableState } from './state.svelte'
 
+  const _features = tableFeatures({
+    ColumnOrdering,
+    ColumnVisibility,
+  })
+
   const columns: ColumnDef<any, Person>[] = [
     {
       header: 'Name',
@@ -75,7 +80,9 @@
   const [columnVisibility, setColumnVisibility] =
     createTableState<ColumnVisibilityState>({})
 
-  const options: TableOptions<any, Person> = {
+  const options: TableOptions<typeof _features, Person> = {
+    _features,
+    _rowModels: {},
     get data() {
       return data
     },
@@ -90,8 +97,6 @@
     },
     onColumnOrderChange: setColumnOrder,
     onColumnVisibilityChange: setColumnVisibility,
-    getCoreRowModel: createCoreRowModel(),
-    getSortedRowModel: createSortedRowModel(),
     debugTable: true,
   }
 

diff --git a/examples/svelte/column-pinning/package.json b/examples/svelte/column-pinning/package.json
@@ -16,7 +16,7 @@
     "@sveltejs/vite-plugin-svelte": "^4.0.0-next",
     "@tanstack/svelte-table": "^9.0.0-alpha.10",
     "@tsconfig/svelte": "^5.0.4",
-    "svelte": "^5.0.0-next",
+    "svelte": "5.0.0-next.260",
     "svelte-check": "^3.8.4",
     "typescript": "5.4.5",
     "vite": "^5.3.2"