Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve typing on makeStateUpdater function #5878

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jmtoung
Copy link

@jmtoung jmtoung commented Jan 19, 2025

This commit makes a few typescript improvements:

  • use a typeguard in the functionalUpdate function instead of casting
  • properly type the second argument to makeStateUpdater as Table<TData>
  • remove generic parameter on input to instance.setState, and instead type it properly as TableState, removing the need for casting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant