refactor: (#301) 리뷰 적용

Team-ComIT · Jan 23, 2023 · a33df46 · a33df46
1 parent 32ada85
commit a33df46
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/simtong-presentation/src/main/kotlin/team/comit/simtong/domain/common/WebCommonAdapter.kt b/simtong-presentation/src/main/kotlin/team/comit/simtong/domain/common/WebCommonAdapter.kt
@@ -1,6 +1,5 @@
 package team.comit.simtong.domain.common
 
-import org.hibernate.validator.constraints.Range
 import org.springframework.http.HttpStatus
 import org.springframework.validation.annotation.Validated
 import org.springframework.web.bind.annotation.*
@@ -13,7 +12,6 @@ import team.comit.simtong.domain.spot.usecase.ShowSpotListUseCase
 import team.comit.simtong.domain.team.dto.QueryTeamsResponse
 import team.comit.simtong.domain.team.usecase.QueryTeamsUseCase
 import team.comit.simtong.domain.user.dto.response.FindEmployeeNumberResponse
-import team.comit.simtong.domain.user.model.EmployeeNumber
 import team.comit.simtong.domain.user.usecase.ChangePasswordUseCase
 import team.comit.simtong.domain.user.usecase.CheckEmailDuplicationUseCase
 import team.comit.simtong.domain.user.usecase.CheckMatchedAccountUseCase
@@ -87,8 +85,7 @@ class WebCommonAdapter(
 
     @GetMapping("/account/existence")
     fun checkMatchedAccount(
-        @NotNull @Range(min = EmployeeNumber.MIN_VALUE, max = EmployeeNumber.MAX_VALUE)
-        @RequestParam employeeNumber: Int?,
+        @NotNull @RequestParam employeeNumber: Int?,
         @NotEmpty @Email @RequestParam email: String?
     ) {
         checkMatchedAccountUseCase.execute(

diff --git a/simtong-presentation/src/main/kotlin/team/comit/simtong/domain/email/WebEmailAdapter.kt b/simtong-presentation/src/main/kotlin/team/comit/simtong/domain/email/WebEmailAdapter.kt
@@ -13,8 +13,8 @@ import team.comit.simtong.domain.auth.usecase.SendAuthCodeUseCase
 import team.comit.simtong.domain.email.dto.SendAuthCodeRequest
 import javax.validation.Valid
 import javax.validation.constraints.Email
+import javax.validation.constraints.NotBlank
 import javax.validation.constraints.NotEmpty
-import javax.validation.constraints.NotNull
 
 /**
  *
@@ -40,7 +40,7 @@ class WebEmailAdapter(
     @GetMapping
     fun checkAuthCode(
         @NotEmpty @Email @RequestParam email: String?,
-        @NotNull @Length(min = 6, max = 6) @RequestParam code: String?
+        @NotBlank @Length(min = 6, max = 6) @RequestParam code: String?
     ) {
         checkAuthCodeUseCase.execute(
             email = email!!,