public 이미지를 assets 으로 옮기기
#239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tro block of main section 4
…ntro block of main section 4
…ntro block of main section 4
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- Replace static image URLs with imported image modules in the MatchingSequenceSwiper component. This shift allows for stronger type checking and potential optimizations by the module bundler. - Simplify the props passed to the `MainDescriptionCard` by using a single `image` object instead of separate URL, width, and height properties, streamlining component interfaces and reducing redundancy. These changes enhance maintainability and prepare the component for more flexible image management, such as easier transitions to different image formats or dynamic loading techniques.
- Update the `StyledSection` to use a column layout with centered alignment, improving the structural hierarchy and visual alignment on various screen sizes. - Adjust `ImageContainer` to be fully responsive by setting its width to 100% and constraining its maximum width to 1200px. This ensures the image scales properly within larger viewports while maintaining a reasonable size limit. These changes are aimed at enhancing the visual appeal and responsiveness of the MainSection2, ensuring it looks optimal on different devices.
- Encapsulate the CardSwiper component within a new SwiperContainer for improved structure and responsiveness. This change adds an extra layer of flexibility in managing the positioning and styling of the swiper. - Remove outdated `overflow: hidden;` from the Block styled component, simplifying the CSS and eliminating unused styles. - Minor adjustments to styling to accommodate these structural changes, including better organization and separation of styled components for clarity and maintenance. These modifications aim to enhance the visual presentation and manageability of the swiper component within the IntroRecommendBlock, ensuring it better suits various device layouts.
- Amend the Dockerfile to copy `next-env.d.ts` and `svgr.d.ts` files along with the existing `next.config.js` and `tsconfig.json`. This ensures that all necessary TypeScript definition files are available in the Docker image, supporting proper type-checking and configuration during the build process. - These changes aim to enhance build stability and maintain consistency across development and production environments by ensuring all relevant configuration files are included in the Docker build context. This adjustment ensures that the Docker environment mirrors the local development setup more closely, potentially reducing issues related to environment discrepancies.
jaewoongs
approved these changes
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경 개요
구현 내용
public폴더 이미지를 소스코드 안으로 옮겼어요https://nextjs.org/docs/app/building-your-application/optimizing/static-assets#caching
관련 이슈