Powered machines not updating state correctly #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d not present. As such, if you toggle a machine to 'requires redstone' the machine gets stuck showing that it is active. For example, if a StirlingGenerator is changed to required redstone the generator keeps showing its active animation despite no being active.
ferriarnus
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
State was only being updated when canUse returned true. This meant that if the state changed so that canUse went from true to false the state change was not applied.
An example of this occurring is turning on 'only active with redstone signal'. This results in canUse returning false so the the check fails and the state update is not made. This results, for example, the StirlingGen block still showing its active 'running' block on the client when it has been disabled.
Checklist