Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Farming Station #568

Open
wants to merge 39 commits into
base: dev/1.21.1
Choose a base branch
from
Open

Farming Station #568

wants to merge 39 commits into from

Conversation

ferriarnus
Copy link
Member

@ferriarnus ferriarnus commented Nov 23, 2023 •
edited by dphaldes
Loading

Description

Adding the farming station

Closes #142

Todo

  • Make proper API
  • Energy balance
  • Model

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have performed a self-review of my own code.
  • I have commented my code in areas it may be challenging to understand.
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

@Rover656
Copy link
Member

Does this supersede/build on #463 ?

@dphaldes dphaldes added Type-Enhancement New feature or enhancement to existing feature. Area-Parity 1.12.2 missing features labels Feb 13, 2024
@ferriarnus ferriarnus changed the base branch from dev/1.20.1 to dev/1.20.4 March 4, 2024 00:31
@dphaldes dphaldes mentioned this pull request Apr 20, 2024
Closed
8 tasks
@ferriarnus ferriarnus changed the base branch from dev/1.20.4 to dev/1.20.6 May 18, 2024 23:32
@ferriarnus ferriarnus marked this pull request as ready for review June 14, 2024 21:56
@ferriarnus ferriarnus changed the title [WIP] Add Farming Station Farming Station Jun 16, 2024
@Rover656
Copy link
Member

Rover656 commented Jul 3, 2024

Before I review, is this PR functionality-wise complete?

@ferriarnus
Copy link
Member Author

I think so yes

@Rover656
Copy link
Member

Rover656 commented Jul 7, 2024

Not possible to merge this into 1.21 as-is, but I will help you with the migration to 1.21 after the project reorganisation :)

@Rover656 Rover656 added the Status-Needs Updating Needs updating to a newer Minecraft version. label Jul 18, 2024
@ferriarnus ferriarnus changed the base branch from dev/1.20.6 to dev/1.21 September 29, 2024 21:57
@Rover656 Rover656 changed the base branch from dev/1.21 to dev/1.21.1 September 30, 2024 16:39
@dphaldes
Copy link
Contributor

dphaldes commented Jan 9, 2025

@Rover656 how do I get the CI to work? If I run spotless locally, it changes a bunch of things unrelated to this PR

@thatmaxplayle
Copy link

Hey everyone! 👋

Just wondering if there's any progress on this (as a new viewer of the project) as I'm looking to backport this implementation into the 1.20.1 version, for my personal server.

If anyone could give me any heads up/OK to go ahead with that, I'd be much appreciative.

Cheers! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area-Parity 1.12.2 missing features MC-1.20.6 Status-Needs Updating Needs updating to a newer Minecraft version. Type-Enhancement New feature or enhancement to existing feature.
Projects
None yet
Milestone
7.2 Update
Development

Successfully merging this pull request may close these issues.

Farming Station
4 participants
@ferriarnus @Rover656 @dphaldes @thatmaxplayle