Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VAT recipes for some missing fluids #746

Draft
wants to merge 3 commits into
base: dev/1.21.1
Choose a base branch
from

Conversation

ferriarnus
Copy link
Member

Description

Adds VAT recipes to our fluids if they have a use.

TODO

  • Further balancing and renaming.

Breaking Changes

List any breaking changes in this section, such as: changed/removed APIs, changed or removed items/blocks or modifications to recipes and gameplay mechanics.

Checklist

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

@Rover656 Rover656 requested a review from dphaldes July 16, 2024 20:39
@dphaldes
Copy link
Contributor

You can replace the existing Hootch recipe. It was a temporary one for testing purposes.

@dphaldes
Copy link
Contributor

I would also prefer if all tags were our own and not default forge ones. For example, instead of Tags.Items.Meat use our own MachineTags.Meat. You can by default add forge meat to it. It would give better control to modpacks in case they want to tweak it.

@Rover656
Copy link
Member

I would also prefer if all tags were our own and not default forge ones. For example, instead of Tags.Items.Meat use our own MachineTags.Meat. You can by default add forge meat to it. It would give better control to modpacks in case they want to tweak it.

Personally I disagree with this to be honest, it just adds more confusion/indirection for less experienced modpack devs. If there's a common tag we should use that unless there is good reason to have our own tag.

@dphaldes
Copy link
Contributor

I would also prefer if all tags were our own and not default forge ones. For example, instead of Tags.Items.Meat use our own MachineTags.Meat. You can by default add forge meat to it. It would give better control to modpacks in case they want to tweak it.

Personally I disagree with this to be honest, it just adds more confusion/indirection for less experienced modpack devs. If there's a common tag we should use that unless there is good reason to have our own tag.

Even if our tag has the forge tag inside it ?
(btw regilite will need a patch for tags to ensure tags are not overwritten. Not sure if this has been addressed already)

@Rover656
Copy link
Member

Rover656 commented Jul 17, 2024

Even if our tag has the forge tag inside it ?

Yeah, I just don't think our tag would be used ever - if you're changing an item to count as meat, you'd be doing it under c:

(btw regilite will need a patch for tags to ensure tags are not overwritten. Not sure if this has been addressed already)

Soon ™️

@Rover656 Rover656 changed the base branch from dev/1.21 to dev/1.21.1 September 30, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants