PneumaticCraft Pressure Conduits #849
Conversation
There was a problem hiding this comment.
Just a handful of code style comments. After a quick pass the conduit code looks good and I'll test it in game another day -but- I have a question about the air context. When a conduit graph is split in half, there's going to be no loss of air and they'll both become over-pressure. Is there any way we can make the air drop and balance between the two graphs?
This of course hasn't been done by the energy conduits because they just clamp the storage back down to the capacity - this might be a case where the changes I was going to propose to Graph Lib could come in handy to properly split the resource across the two contexts.
| } | ||
|
|
||
| if (otherConduit.value() instanceof PressureConduit other) { | ||
|
|
There was a problem hiding this comment.
Could you prune this blank space please :)
| import java.util.List; | ||
|
|
||
| public record PressureConduitStorage(PressureTier tier, ConduitNode node) implements IAirHandlerMachine { | ||
|
|
There was a problem hiding this comment.
Another line here please (auto-formatting PR soon ™️)
| @@ -4,7 +4,7 @@ org.gradle.daemon=false | |||
|
|
|||
| # Minecraft and NeoForge | |||
| minecraftVersion=1.21.1 | |||
| neoForgeVersion=21.1.58 | |||
There was a problem hiding this comment.
Did we bump because .60 is required for Ender IO, or for Pneumaticraft?
| } | ||
|
|
||
| @Override | ||
| public void onConnectTo(ConduitNode selfNode, ConduitNode otherNode) { | ||
| FluidConduitData selfData = selfNode.getOrCreateData(ConduitTypes.Data.FLUID.get()); | ||
| FluidConduitData otherData = otherNode.getOrCreateData(ConduitTypes.Data.FLUID.get()); | ||
|
|
||
| if (selfData.lockedFluid() != null) { |
There was a problem hiding this comment.
Could we lift the fluid conduit fixes into a different PR, currently fluid conduits are completely borked and it'd be good to handle these separately 😅
Description
Pressure conduits for PneumaticCraft.
TODO
Breaking Changes
List any breaking changes in this section, such as: changed/removed APIs, changed or removed items/blocks or modifications to recipes and gameplay mechanics.
Checklist