[FIX]액션 플랜 조회 시 리뷰가 달린 액션플랜인지 포함하여 반환 #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeseul106
approved these changes
Jan 16, 2024
| @@ -17,4 +17,6 @@ public class ActionPlanGetResponseDto { | |||
| private Boolean isScraped; | |||
|
|
|||
| private Boolean isFinished; | |||
|
|
|||
| private Boolean isReviewed; | |||
There was a problem hiding this comment.
사소한거지만, seed에 actionPlan이 있는지에 대한 변수명으로 hasActionPlan으로 개발했었어서 통일성을 위해 hasReview는 어떤지 여쭤보고 싶어요 ~!
There was a problem hiding this comment.
오 완전 좋은 의견이라고 생각합니다!!다음 PR에 얹어서 수정해놓겠습니다!! 감사합니당 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📣 Related Issue
📝 Summary
🙏 Question & PR point
📬 Reference