refactor :: 독후감 권수 누적

Team-MindWay · Apr 22, 2024 · e622d31 · e622d31
1 parent 73bd96e
commit e622d31
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 9 deletions.
diff --git a/src/main/java/com/mindway/server/v2/domain/book/service/impl/BookWriteServiceImpl.java b/src/main/java/com/mindway/server/v2/domain/book/service/impl/BookWriteServiceImpl.java
@@ -30,11 +30,17 @@ public void execute(BookWriteRequest bookWriteRequest) {
     }
 
     private void accrue(User user) {
-        Ranks rank = rankRepository.findByUser(user);
-        if (rank == null) {
-            rank = new Ranks(user);
-        }
+        Ranks rank = rankRepository.findByUser(user)
+                .orElseGet(() -> saveUserRank(user));
+
         rank.accrue();
         rankRepository.save(rank);
     }
+
+    private Ranks saveUserRank (User user) {
+        return Ranks.builder()
+                .user(user)
+                .accrue(0)
+                .build();
+    }
 }
diff --git a/src/main/java/com/mindway/server/v2/domain/rank/entity/Ranks.java b/src/main/java/com/mindway/server/v2/domain/rank/entity/Ranks.java
@@ -3,20 +3,22 @@
 import com.mindway.server.v2.domain.user.entity.User;
 import jakarta.persistence.*;
 import lombok.AllArgsConstructor;
+import lombok.Builder;
 import lombok.Getter;
 import lombok.NoArgsConstructor;
 
 @Entity
 @NoArgsConstructor
 @AllArgsConstructor
+@Builder
 @Getter
 public class Ranks {
 
     @Id
     @GeneratedValue(strategy = GenerationType.IDENTITY)
     private Long id;
 
-    private Integer accrue = 0;
+    private Integer accrue;
 
     @ManyToOne
     @JoinColumn(name = "user_id")
@@ -26,7 +28,4 @@ public void accrue() {
         accrue++;
     }
 
-    public Ranks(User user) {
-        this.user = user;
-    }
 }
diff --git a/src/main/java/com/mindway/server/v2/domain/rank/repository/RankRepository.java b/src/main/java/com/mindway/server/v2/domain/rank/repository/RankRepository.java
@@ -5,9 +5,10 @@
 import org.springframework.data.jpa.repository.JpaRepository;
 
 import java.util.List;
+import java.util.Optional;
 
 public interface RankRepository extends JpaRepository<Ranks, Long> {
     List<Ranks> findTop3ByOrderByAccrueDesc();
 
-    Ranks findByUser(User user);
+    Optional<Ranks> findByUser(User user);
 }