도서 추천 api #105
Merged
도서 추천 api #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Umjiseung
reviewed
Apr 23, 2024
|
|
||
| @NotBlank | ||
| private String author; | ||
| } |
There was a problem hiding this comment.
제가 알기론 숫자가 들어가면 @NotBlank가 적합하지 않는 걸로 아는데 맞나요?
Comment on lines
29
to
33
| } | ||
|
|
||
| recRepository.save(recConverter.toEntity(writeRecRequest, type)); | ||
| } | ||
| } |
There was a problem hiding this comment.
저희 코드 스타일이 컨버터로 변환하고 그걸 객체를 따로 만들어서 save하는 느낌인걸로 알고 있어요
코드를 일관성있게 하면 좋을 거 같아요
| @@ -81,6 +81,9 @@ public SecurityFilterChain filterChain(HttpSecurity http) throws Exception { | |||
| // rank | |||
| .requestMatchers(HttpMethod.GET, "/api/v2/rank").authenticated() | |||
|
|
|||
| // recommend | |||
| .requestMatchers(HttpMethod.POST, "/api/v2/recommend").hasAnyAuthority(Authority.ROLE_TEACHER.name(), Authority.ROLE_STUDENT.name()) | |||
|
|
|||
There was a problem hiding this comment.
권한 허용이 잘못 되어있는거같은데요? 수정부탁드려요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 개요
도서 추천 api를 구현했습니다
📃 작업내용
도서 추천 api를 구현했습니다
novel / essay 두 개의 타입을 가지고 있고
선생님 또는 도서부만 작성할 수 있습니다
🔀 변경사항
🙋♂️ 질문사항
⚗️ 사용법
🎸 기타