도서 신청 조회 api #45
Merged
도서 신청 조회 api #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ta2ye0n
requested review from
enbraining,
yusung103 and
Umjiseung
as code owners
Closed
Umjiseung
reviewed
Apr 7, 2024
| public ResponseEntity<List<OrdersResponse>> bookOrders () { | ||
| List<OrdersResponse> orders = getBookOrdersService.execute(); | ||
| return ResponseEntity.ok(orders); | ||
| } |
There was a problem hiding this comment.
bookOrders라는 메서드만 봐서는 무슨 역할을 하는 메서드인지 모르겠어요..
이름 다시 생각해보시는게 좋을거같아요!
There was a problem hiding this comment.
신청도서 불러오는거라 getBookOrders로 바꿨는데 이건 어떤거 같나요??
Comment on lines
35
to
41
|
|
||
| List<Orders> orders = ordersRepository.findAll(); | ||
|
|
||
| return orders.stream() | ||
| .map(ordersConverter::toDto) | ||
| .collect(Collectors.toList()); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 개요
신청한 도서 목록을 조회하는 api를 구현했습니다
📃 작업내용
신청한 도서 목록을 확인할 수 있습니다.
도서부 또는 선생님만 확인할 수 있으며 일반 학생일 경우 예외가 발생합니다
🔀 변경사항
🙋♂️ 질문사항
⚗️ 사용법
🎸 기타