독후감 리스트 반환 api #98
Merged
독후감 리스트 반환 api #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Umjiseung
reviewed
Apr 20, 2024
|
|
||
| @Override | ||
| public BookListResponse toListDto(Book book) { | ||
| return BookListResponse.builder() |
| private String plot; | ||
| private String date; | ||
| } | ||
|
|
There was a problem hiding this comment.
date를 String말구 LocalDate로 하는 건 어떤가요??
그러면 BookConverter에서 굳이 형식을 지정하지 않아도 되고 간결해질 거 같아요!
| .plot(book.getPlot()) | ||
| .date(book.getCreateAt().format(DateTimeFormatter.ofPattern("yyyy-MM-dd"))) | ||
| .build(); | ||
| } |
There was a problem hiding this comment.
public BookListResponse toListDto(Book book) {
return BookListResponse.builder()
.id(book.getId())
.title(book.getTitle())
.plot(book.getPlot())
.date(LocalDate.from(book.getCreateAt()))
.build();
}이렇게 수정하면 될거같아요오
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 개요
독후감 리스트 반환 api를 구현했습니다
📃 작업내용
독후감 리스트 반환 api를 구현했습니다
본인이 아닐 경우 예외가 발생합니다
🔀 변경사항
🙋♂️ 질문사항
⚗️ 사용법
🎸 기타