Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fcm 단체 전송 시 토큰값 null체크, s3 불필요 로그 삭제 #253

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

jun3327
Copy link
Contributor

@jun3327 jun3327 commented Nov 14, 2024

변경사항

  • 공지사항 전송 시 전체 회원의 토큰을 추가할 때 토큰값이 한명이라도 null일 경우 Fcm sdk에서 exception이 발생해서, 토큰에 대한 null 체크를 추가했습니다.
  • s3 presign url 처음 구현할때 디버깅 용도로 썼던 로그가 불필요하게 많이 쌓여있어서 해당 로깅 부분을 삭제했습니다

고려사항

Comment

Test

질문사항

@jun3327 jun3327 added the Chore tiny change label Nov 14, 2024
@jun3327 jun3327 self-assigned this Nov 14, 2024
@jun3327 jun3327 requested a review from a team as a code owner November 14, 2024 06:06
@jun3327 jun3327 merged commit bc0ddd4 into develop Nov 14, 2024
1 check passed
@jun3327 jun3327 deleted the task/fix-announcement-sending branch November 14, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore tiny change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant