[Feat] OverView, PlaceDetail뷰 구현 #164
Open
+1,345
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sozohoy
reviewed
Oct 30, 2024
|
|
||
| public class PlaceDetailButton: UIButton { | ||
|
|
||
| public var place: Place? |
| import Core | ||
|
|
||
| final class ExhibitionListView: UIView { | ||
| private var exhibitionData: Place? |
There was a problem hiding this comment.
p2
데이터를 들고 있는 이유가 무엇인가요?
만약 들고 있어야 한다면, place로 네이밍을 수정하는 것이 좋아보여요
Comment on lines
+143
to
+165
| private func createCollectionView() -> UICollectionView { | ||
| let layout = UICollectionViewFlowLayout() | ||
| layout.scrollDirection = .horizontal | ||
| layout.minimumLineSpacing = 12 | ||
| layout.itemSize = CGSize(width: 135, height: 240) | ||
| layout.sectionInset = UIEdgeInsets( | ||
| top: 0, | ||
| left: 0, | ||
| bottom: 0, | ||
| right: 0 | ||
| ) | ||
|
|
||
| let collectionView = UICollectionView( | ||
| frame: .zero, | ||
| collectionViewLayout: layout | ||
| ) | ||
| collectionView.showsHorizontalScrollIndicator = false | ||
| collectionView.register( | ||
| UICollectionViewCell.self, | ||
| forCellWithReuseIdentifier: "DefaultCell" | ||
| ) | ||
| collectionView.delegate = self | ||
| collectionView.dataSource = self |
There was a problem hiding this comment.
p3
컬뷰를 구현하도록 리턴한 이유가 무엇인가요?
There was a problem hiding this comment.
configureStackView()에 작성하려고 컬뷰를 리턴했어요
OverView 화면에서 전시 공간 개수만큼 (버튼, 컬뷰) 세트를 만들어야 하는걸로 알고 있어서
for문 돌면서 (버튼, 컬뷰)를 동적 생성해줬고, 컬뷰를 생성하는 함수는 별도로 작성한것입니당
Comment on lines
+171
to
+177
| if sender == exhibitionListView.allFilterButton { | ||
| viewModel.updateFilterState(selected: .all) | ||
| } else if sender == exhibitionListView.freeFilterButton { | ||
| viewModel.updateFilterState(selected: .free) | ||
| } else if sender == exhibitionListView.endSoonFilterButton { | ||
| viewModel.updateFilterState(selected: .endSoon) | ||
| } |
Comment on lines
+197
to
+201
| viewModel.onFilterChanged?( | ||
| viewModel.allFilterState, | ||
| viewModel.freeFilterState, | ||
| viewModel.endSoonFilterState | ||
| ) |
There was a problem hiding this comment.
p2
뷰모델 내부에서 내부의 상태를 변경하는게 더 적합해 보입니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 PR Content
홈 화면에 해당하는 OverView, PlaceDetail의 UI와 관련 로직을 구현했습니다.
📸 Screenshot
Simulator.Screen.Recording.-.iPhone.13.pro.-.2024-10-30.at.17.33.19.mp4
📍 PR Point
OverView에 있는 장소 개수만큼 버튼, 컬렉션뷰를 동적 생성합니다.PlaceDetailButton을 누르면 장소에 대한 데이터를 가지고PlaceDetailVC로 이어집니다.PlaceDetailVC에서전시 리스트,후기 영상을 보여주는SegmentedControl을 구현했습니다전시 리스트에서Place-PlaceInfo의 개수만큼 해당 장소의 전시에 대한 Cell이 생성됩니다.resolve #154