Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] 뱃지 전체 조회로 수정 #190

Merged
merged 4 commits into from
Jan 17, 2024
Merged

[FIX] 뱃지 전체 조회로 수정 #190

merged 4 commits into from
Jan 17, 2024

Conversation

thguss
Copy link
Member

@thguss thguss commented Jan 16, 2024

Related issue 🚀

Work Description 💚

  • 직전 PR과 중복되는 내용이 있어 직전 PR 병합 후 코드 리뷰 부탁드려요!
  • 뱃지 전체 조회(뱃지 있으면 컬러, 없으면 흑백) 기능을 수정했습니다.
  • Fixture 및 Test 코드 일부 수정했습니다.
  • 일부 사용하지 않는 코드들을 삭제했습니다.
image

@thguss thguss added SOHYEON 🐣 소현 작업 FIX labels Jan 16, 2024
@thguss thguss requested a review from unanchoi January 16, 2024 18:16
@thguss thguss self-assigned this Jan 16, 2024
unanchoi
unanchoi approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@unanchoi unanchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와 코드도 깔끔하고 Test Code 수정까지 깔끔하게 작성하셨네요 ..! 너무 수고 많으셨습니다..!

@thguss thguss merged commit d329e55 into develop Jan 17, 2024
1 check passed
@thguss thguss deleted the sohyeon_#187 branch January 17, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unanchoi unanchoi unanchoi approved these changes

Assignees

@thguss thguss

Labels
FIX SOHYEON 🐣 소현 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX] 뱃지 리스트 조회 수정
2 participants
@thguss @unanchoi