[REFACTOR] 3차 리팩토링 진행 #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thguss
approved these changes
Feb 27, 2024
| } catch (AuthException exception) { | ||
| log.error("error : ", exception); | ||
| final String token = getJwtFromRequest(request); | ||
| if (StringUtils.hasText(token) && tokenValidator.validateToken(token) == VALID_JWT) { |
There was a problem hiding this comment.
if문 내부 코드가 별도 메소드로 분리되면 좋을 것 같아요 :)
...
if (isValidToken(token)) {
...
}
...
private boolean isValidToken(String token) {
return StringUtils.hasText(token) && tokenValidator.validateToken(token) == VALID_JWT;
}| log.error("error : ", exception); | ||
| final String token = getJwtFromRequest(request); | ||
| if (StringUtils.hasText(token) && tokenValidator.validateToken(token) == VALID_JWT) { | ||
| Long userId = tokenValidator.getUserFromJwt(token); |
There was a problem hiding this comment.
null로 들어오는 경우가 있나요?? 래퍼타입(Long)이라 잘 몰라서 물어봅니닷!
| import lombok.AccessLevel; | ||
| import lombok.Builder; | ||
|
|
||
| @Builder(access = AccessLevel.PRIVATE) |
There was a problem hiding this comment.
컨벤션 통일을 위해 ENUM 타입은 import static으로 변경되면 좋을 것 같아요!
Comment on lines
32
to
34
| return badges.stream() | ||
| .map(badge -> BadgeBaseServiceResponse.of(badge, memberBadges)) | ||
| .toList(); |
Comment on lines
23
to
24
| // 첫 글자가 공백인 경우 | ||
| return !(username.charAt(0) == ' '); | ||
| return !(Objects.equals(username.charAt(0),' ')); |
There was a problem hiding this comment.
코드로 충분히 파악할 수 있다고 생각하여, 주석은 제거해도 좋을 것 같다고 생각해요!
| @@ -164,7 +164,7 @@ private void updateGoalType(Member member, GoalType goalType) { | |||
| } | |||
| } | |||
|
|
|||
| private void updatePushAlarmConsent(Member member, Boolean hasAlarm) { | |||
| private void updatePushAlarmConsent(Member member, final Boolean hasAlarm) { | |||
There was a problem hiding this comment.
hasAlarm은 null이 들어올 수 있는 데이터인가용??
There was a problem hiding this comment.
Entity 내부 메소드에서 null 체크 로직 포함하는 것으로 논의
Comment on lines
66
to
70
| return appleKeyList.keys().stream() | ||
| .filter(appleKey -> | ||
| Objects.equals(decodedAppleKey.alg(), appleKey.alg()) && | ||
| Objects.equals(decodedAppleKey.kid(), appleKey.kid()) | ||
| ) |
There was a problem hiding this comment.
Objects.equals(decodedAppleKey.alg(), appleKey.alg()) &&
Objects.equals(decodedAppleKey.kid(), appleKey.kid())해당 코드도 별도 메소드로 추출하면 직관적으로 가독성이 더 좋아질 것 같아요!
|
|
||
| public String getKakaoData(final String accessToken) { | ||
| try { | ||
| RestClient restClient = RestClient.create(); |
There was a problem hiding this comment.
RestClient는 val 타입으로 지정하지 않은 이유가 있을까요??
unanchoi
force-pushed
the
refactor_#198_unan3
branch
from
1537d31 to
a595bf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🚀
Work Description 💚
3차 리팩토링을 진행했습니다.