Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Member, Badge Controller Response DTO 교체 #218

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Conversation

unanchoi
Copy link
Contributor

@unanchoi unanchoi commented Mar 3, 2024

Related issue 🚀

Work Description 💚

  • MemberController Response DTO를 ServiceResponse 에서 교체했습니다.
  • BadgeController Response DTO를 ServiceResponse 에서 교체했습니다.

리팩토링 하면서 놓친 부분들이 조금씩 있네요 ...!

@unanchoi unanchoi added BUGFIX BUG를 해결했을 때 UNAN🐻 Unan 작업 labels Mar 3, 2024
@unanchoi unanchoi requested a review from thguss March 3, 2024 15:02
@unanchoi unanchoi self-assigned this Mar 3, 2024
Copy link
Member

@thguss thguss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~
디코에서 요청받은 langType 필드 이름 이슈는 아직 적용 안 된 것 맞나요?? 맞다면 해당 PR에 같이 적용해서 머지해도 좋을 듯 합니다!

@unanchoi
Copy link
Contributor Author

unanchoi commented Mar 4, 2024

수고하셨습니다~ 디코에서 요청받은 langType 필드 이름 이슈는 아직 적용 안 된 것 맞나요?? 맞다면 해당 PR에 같이 적용해서 머지해도 좋을 듯 합니다!

@thguss

제가 디테일하게 설명을 안해놨네요.
MemberController에서 MemberGetServiceResponse를 MemberGetResponse로 바꿔서 해결했습니다 !
MemberGetServiceResponse에서 targetLangType이라는 변수를 사용하고 있어서, API Response가 targetLangType으로 내려갔었는데, MemberGetResponse로 대체해서, langType 필드이름 이슈는 해결되었습니다.!

@thguss
Copy link
Member

thguss commented Mar 4, 2024

@unanchoi
상세한 설명 감사합니다!
머지 고고~!

@unanchoi unanchoi merged commit 1404e99 into develop Mar 5, 2024
1 check passed
@unanchoi unanchoi deleted the fix_#217_unan branch March 5, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUGFIX BUG를 해결했을 때 UNAN🐻 Unan 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] MemberController API Response 수정
2 participants