Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] 학습 계획 설정 API 수정 #225

Merged
merged 5 commits into from
Mar 11, 2024
Merged

[FIX] 학습 계획 설정 API 수정 #225

merged 5 commits into from
Mar 11, 2024

Conversation

unanchoi
Copy link
Contributor

@unanchoi unanchoi commented Mar 11, 2024 •
edited
Loading

Related issue 🚀

Work Description 💚

  • 현재 학습 계획 설정 API에서, 스펙상으로는 TrainingTimeRequest를 null로 보낼 수 있지만 nullable하지 않아, 요청시에 오류가 발생하고 있습니다. 해당 부분을 수정했어요~
  • 관련 노션 API 명세서에는 댓글로 언급 해두겠습니다.
  • 로직 자체가 Null - Safety가 많이 떨어지는 것 같아서, 수정 방향도 고려해보면 좋겠네요 ~~
  • Spring Boot 3.2.0에서 생기는 문제가 있다고 하여, 3.2.1로 올렸습니다. 관련해서 링크 남겨두겠습니다.
  • Spring Boot 3.2.0 Cache miss for REQUEST dispatch to '/actuator/health/readiness' spring-projects/spring-boot#38587

스크린샷

  • 각각 요청 보내는 상황에 대해서 모두 성공하는지 test해봤습니다..>!
image image image

@unanchoi unanchoi added BUGFIX BUG를 해결했을 때 API API 관련 labels Mar 11, 2024
@unanchoi unanchoi requested a review from thguss March 11, 2024 14:04
@unanchoi unanchoi self-assigned this Mar 11, 2024
thguss
thguss approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@thguss thguss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

...m-api/src/main/java/com/smeem/api/member/service/dto/request/TrainingTimeServiceRequest.java Outdated
) {
public static TrainingTimeServiceRequest of(TrainingTimeRequest request) {
if (request == null) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Objects.isNull() 메소드 사용도 컨벤션 통일을 위해 한 번 고려해주세요~!

@unanchoi unanchoi merged commit 8618e8e into develop Mar 11, 2024
@unanchoi unanchoi deleted the fix_#224_unan branch March 11, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thguss thguss thguss approved these changes

Assignees

@unanchoi unanchoi

Labels
API API 관련 BUGFIX BUG를 해결했을 때
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX] 사용자 학습계획 변경 API 버그 픽스
2 participants
@unanchoi @thguss