[REFACTOR] DiscordAlarmSender -> DiscordService interface로 교체 #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thguss
approved these changes
May 7, 2024
Comment on lines
53
to
64
| @Transactional | ||
| public MemberUpdateServiceResponse updateUserProfile(final MemberServiceUpdateUserProfileRequest request) { | ||
| checkMemberDuplicate(request.username()); | ||
| val member = memberFinder.findById(request.memberId()); | ||
| updateTermAccepted(member, request); | ||
| @Transactional | ||
| public MemberUpdateServiceResponse updateUserProfile(final MemberServiceUpdateUserProfileRequest request) { | ||
| checkMemberDuplicate(request.username()); | ||
| val member = memberFinder.findById(request.memberId()); | ||
| updateTermAccepted(member, request); | ||
|
|
||
| ArrayList<Badge> badges = new ArrayList<>(); | ||
| if (isNewMember(member)) { | ||
| addWelcomeBadge(member, badges); | ||
| discordAlarmSender.send(SIGN_IN_MESSAGE + member.getId(), INFO); | ||
| } | ||
| member.updateUsername(request.username()); | ||
| ArrayList<Badge> badges = new ArrayList<>(); | ||
| if (isNewMember(member)) { | ||
| addWelcomeBadge(member, badges); | ||
| discordService.send(SIGN_IN_MESSAGE + member.getId(), INFO); | ||
| } | ||
| member.updateUsername(request.username()); |
| @@ -0,0 +1,5 @@ | |||
| package com.smeem.external.discord; | |||
|
|
|||
| public interface DiscordService { | |||
There was a problem hiding this comment.
인터페이스의 목적 중 하나가 계층 간 의존성을 줄이기 위함이라고 생각해요.
Discord라는 의존성을 드러내는 대신, AlarmService와 같이 목적성을 나타내는 네이밍은 어떤가요!?
Ex. 푸시알람은 NotificationService 인터페이스와 FcmNotificationService 구현체를 사용하고 있습니다!
There was a problem hiding this comment.
NotificationService의 구현방향 통일성을 위해 수정하겠습니다 ~
그리고 리뷰에 대한 의견으로 AlarmService로 바꾸는 것이 코드적으로는 조금 더 추상화되어 있는 방향인 것에는 동의하는데, 프로젝트 관점에서는 DiscordService로 이후에 만약 알람 기능이 크게 확장되거나, 다른 알람이 추가 될 때 적용하는 방향도 고려해보면 좋을 것 같다는 생각이 들었습니다~
현재는 Discord 알람만 사용하고 있기 때문에, API module의 Service 계층과 ExceptionHandler에서 DiscordAlarm이라는 구체화된 의존성을 명시하고, 이후에 AlarmService 인터페이스를 구현한 다른 구현체가 추가 되는 등 확장을 고려했을 때 적절하게 인터페이스를 다시 정의하는 방향으로 고려해보는 것도 좋을 것 같다는 의견입니다~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🚀
Work Description 💚