-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from changing the images to <sageplot>
s, I think this looks good.
source/02-FN/03.ptx
Outdated
<!--<image source="Images/Graph-with-two-endpoints.jpg"/>--> | ||
<image> | ||
<sageplot> | ||
f(x) = 9/8*(x-4)+4 | ||
p=plot(f, (x, -4, 4), ymin=-7, ymax=7, xmin=-5,xmax=5,color='blue', thickness=3,) | ||
p+=point((4,4),pointsize=50,color='blue') | ||
p+=point((-4,-5),pointsize=50,color='blue') | ||
p | ||
</sageplot> | ||
</image> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use <sageplot>
s for these for consistency. I went ahead and did this one, but the others need to be done as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added the others.
source/02-FN/03.ptx
Outdated
<figure xml:id="graph-of-ray-with-open-endpoint"> | ||
<!-- <image source="Images/Ray-with-open-endpoint.jpg"/> --> | ||
<sageplot> | ||
p=arrow((3,-4), (-4,8),xmin=-6,xmax=5,ymin=-6,ymax=8) | ||
p+=point((3,-4),pointsize=50,color='blue') | ||
p+=point((3,-4),pointsize=10,color='white',zorder=2) | ||
p | ||
</sageplot> | ||
</figure> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretext throws a warning when <sageplot>
s are not in an <image>
. Curious to see if the github action validates this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it gave a green check, but I saw the warning there when I went into the details. I like that I can see the full PreTeXt output there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah either the CLI should be erroring out there, or there should at least be a mode to run it that returns an error code. future work...
No description provided.