Skip to content
This repository has been archived by the owner on Jul 30, 2024. It is now read-only.

Draft of FN3 done! #112

Merged
merged 8 commits into from
Apr 3, 2024
Merged

Draft of FN3 done! #112

merged 8 commits into from
Apr 3, 2024

Conversation

tdegeorge
Copy link
Contributor

No description provided.

Copy link
Collaborator

@siwelwerd siwelwerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from changing the images to <sageplot>s, I think this looks good.

Comment on lines 157 to 166
<!--<image source="Images/Graph-with-two-endpoints.jpg"/>-->
<image>
<sageplot>
f(x) = 9/8*(x-4)+4
p=plot(f, (x, -4, 4), ymin=-7, ymax=7, xmin=-5,xmax=5,color='blue', thickness=3,)
p+=point((4,4),pointsize=50,color='blue')
p+=point((-4,-5),pointsize=50,color='blue')
p
</sageplot>
</image>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use <sageplot>s for these for consistency. I went ahead and did this one, but the others need to be done as well.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the others.

@siwelwerd siwelwerd assigned siwelwerd and StevenClontz and unassigned siwelwerd Apr 3, 2024
@StevenClontz StevenClontz requested a review from siwelwerd April 3, 2024 18:57
Comment on lines 279 to 287
<figure xml:id="graph-of-ray-with-open-endpoint">
<!-- <image source="Images/Ray-with-open-endpoint.jpg"/> -->
<sageplot>
p=arrow((3,-4), (-4,8),xmin=-6,xmax=5,ymin=-6,ymax=8)
p+=point((3,-4),pointsize=50,color='blue')
p+=point((3,-4),pointsize=10,color='white',zorder=2)
p
</sageplot>
</figure>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretext throws a warning when <sageplot>s are not in an <image>. Curious to see if the github action validates this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it gave a green check, but I saw the warning there when I went into the details. I like that I can see the full PreTeXt output there

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah either the CLI should be erroring out there, or there should at least be a mode to run it that returns an error code. future work...

@siwelwerd siwelwerd merged commit 17a2281 into main Apr 3, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants