Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support exact search #11509

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

Thompson3142
Copy link
Contributor

@Thompson3142 Thompson3142 commented Sep 8, 2024

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

The user can now perform an exact search by quoting the search string. Also works in combination with other filters (Video, Channel, etc.). Does NOT work with youtube music filters at the moment.

Relies on the following changes

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Sep 8, 2024
@TobiGr TobiGr added search Anything related to the search function feature request Issue is related to a feature in the app labels Sep 16, 2024
@opusforlife2
Copy link
Collaborator

The feature mentioned in the linked issue is something that Youtube directly provides. This PR offers a nice workaround, and is good to have anyway as well, but I don't think it should be considered as having 'fixed' that issue.

@Thompson3142
Copy link
Contributor Author

You are right that should not count as a fix, taking it out of the PR. Not sure how easy it is to implement, might take a shot at it if i find time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app search Anything related to the search function size/small PRs with less than 50 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants