Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let spawn_blocking handle returning its own value #117

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Let spawn_blocking handle returning its own value #117

merged 1 commit into from
Nov 18, 2023

Conversation

RealOrangeOne
Copy link
Contributor

This means one fewer thing to await on, and spin up inside a request. It might be faster, who knows, but it can't hurt.

This means one fewer thing to await on, and spin up inside a request. It _might_ be faster, who knows, but it can't hurt.
Copy link
Contributor

sweep-ai bot commented Nov 18, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@FireMasterK
Copy link
Member

Thanks!

@FireMasterK FireMasterK merged commit 04e3835 into TeamPiped:main Nov 18, 2023
2 checks passed
@RealOrangeOne RealOrangeOne deleted the native-spawn-blocking-return branch November 18, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants