Skip to content
This repository has been archived by the owner on Nov 2, 2019. It is now read-only.

Adding attributes #22

Merged
merged 1 commit into from
May 29, 2015
Merged

Adding attributes #22

merged 1 commit into from
May 29, 2015

Conversation

AbhiAgarwal
Copy link
Member

Fixing #21
@ethanresnick @grungerabbit

Same drill as ship-site:

Please check! Primarily I was just going to flatten the attribute structure in the JS file. I ended up just adding attribute tags in the index.html instead. I thought going forward because we're changing the structure permanently this would be better.

@ethanresnick
Copy link
Member

@AbhiAgarwal I agree that adding attributes in the code/html, rather than trying to flatten, was the right approach!

On a very quick first pass, this code looks good to me, but @grungerabbit knows the setup much better, so I'll let her do the final review/checks

@AbhiAgarwal
Copy link
Member Author

I'm going to merge this

AbhiAgarwal added a commit that referenced this pull request May 29, 2015
@AbhiAgarwal AbhiAgarwal merged commit cc510fe into master May 29, 2015
@oa495 oa495 deleted the fixes/21/main branch March 5, 2016 18:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants