Yu's movie-site project #315
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khleoth
reviewed
Apr 4, 2023
| </div> | ||
| <ul className="navlinkWrapper"> | ||
| <li className="link"> | ||
| <NavLink to="/">Home</NavLink> |
There was a problem hiding this comment.
Hey!, maybe change this to what it actually is (and says on the page when you open that part) - popular movies?
| <div className="popular-tv-container"> | ||
| {tvList.map((singleTv) => { | ||
| return ( | ||
| <div className="tv-wrapper"> |
There was a problem hiding this comment.
Might I suggest making it easier for you if you use the same classnames on these divs as in the movie parts? That way you don't have to apply css duplicates
| return ( | ||
| <div className="tvDetailsWrapper"> | ||
| <img | ||
| className="tv-imge-backdrop" |
| <div className="title"> | ||
| <h2>{details.title}</h2> | ||
| <div className="rating"> | ||
| <span>{(Math.round(details.vote_average * 10) / 10)}⭐</span> |
There was a problem hiding this comment.
I noticed that some titles, since they have not been released yet, have not gotten any votes on rating yet.
One way to solve that problem, just not displaying 0 and then a star, could be to do a ternary operator that if line 49 = 0 return string "N/A" or something like "Not enough votes"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the link to this project: https://yourmoviesiteby-ym.netlify.app/