-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://master--musical-florentine-5987b8.netlify.app/ #316
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks really good! 🙂 Love the header!
.then((configuredData) => { | ||
setMovieList(configuredData.results); | ||
}) | ||
.catch((error) => console.error(error)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice that you kept this in the code!
<Routes> | ||
<Route path="/" element={<MovieList movieList={movieList} />} /> | ||
<Route path="/404" element={<NotFound />} /> | ||
<Route path="/*" element={<Navigate to="/404" replace />} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the "replace" thing do? I think i missed that in my code 😯
@@ -0,0 +1,71 @@ | |||
.details-page { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job using separate .css files for each component. Basically styled components right 😄👍🏼
@@ -0,0 +1,25 @@ | |||
import React from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job making the button a separate component!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such a great job with this weeks project guys! I really like your take on the styling.
Your code is easy to read, I see you made separate css files for some components and made a reusable button component aswell.
So cool that you made your popcorn icon to spin.
I also really like your README section, it is always interesting to see how you worked on the project. Nice!
No description provided.