-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
W8-movies-Ylva-Karlsson-and-Sandra-Olsson #318
Open
YlvaKarlsson
wants to merge
39
commits into
Technigo:master
Choose a base branch
from
YlvaKarlsson:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
97ca9cf
Initial commit
YlvaKarlsson 399b3f3
Commit made after trying the npm-stuff and it worked
YlvaKarlsson 24546d5
added favicon for fun and test
SandraMadeleine 5ba44ac
fixed a missing tag
SandraMadeleine e56c33e
Added some API-info
SandraMadeleine 59e7f15
Added components
YlvaKarlsson 6fff771
Merge branch 'master' of https://github.com/YlvaKarlsson/project-movies
YlvaKarlsson e7b0f57
Added components
YlvaKarlsson 284202e
Some things are working
YlvaKarlsson c06cf2e
It is still working - wohoo
YlvaKarlsson 46c360f
adding a header text and reducing header links from 4 to 2
SandraMadeleine dcee051
tests
SandraMadeleine 5b79aca
fixed the movie list styling, trying to get details to show on click …
SandraMadeleine 912e113
continued tries to get details to show
SandraMadeleine a2cd2c3
details now show, working on the styling for that page
SandraMadeleine c597090
continued fix on details
SandraMadeleine ada2a54
Fixed detailslink, image now much clearer
SandraMadeleine 7bec286
media queries fixed many placement issues
SandraMadeleine ed1f4d3
minor fix in css
SandraMadeleine 142867f
added some comments
SandraMadeleine 4100bda
ylvas branch
YlvaKarlsson 8c7e99d
Merge branch 'master' of https://github.com/YlvaKarlsson/project-movi…
YlvaKarlsson ca12487
test
YlvaKarlsson 0096dc5
Nearly there
YlvaKarlsson 357fa7a
commit to please vs code
SandraMadeleine e37c1b5
Merge branch 'master' of https://github.com/YlvaKarlsson/project-movies
SandraMadeleine 0c2bb49
added footer
SandraMadeleine 50d3301
fixed h2
SandraMadeleine 92e13c9
fixed the rating styling to look better
SandraMadeleine fd09e22
minor changes
SandraMadeleine b59a968
Merge branch 'master' of https://github.com/YlvaKarlsson/project-movi…
YlvaKarlsson d1d2841
Ylvas branch with fixed footer-links
YlvaKarlsson 45b1407
Changes made after 1:1 with Daniel
YlvaKarlsson d10d7c6
Deleted a comment
YlvaKarlsson 4bff006
added prevent default
SandraMadeleine f41edba
Fixed footer and the links
YlvaKarlsson 6f04d6c
Merge branch 'YlvasTestingBranch'
YlvaKarlsson 909fcaf
Fixed readme
YlvaKarlsson dcf11af
final commit for now
YlvaKarlsson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Reading from stdin via: C:\Users\YLVAKA~1\AppData\Local\Temp\code-stdin-ZF4 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,16 @@ | ||
# Project Movies | ||
|
||
Replace this readme with your own information about your project. | ||
This weeks project is a pair-programming-project in collaboration with Sandra Olsson and Ylva Karlsson from Team Elephants of Technigos Web Dev Boot Camp Spring 2023. | ||
|
||
Start by briefly describing the assignment in a sentence or two. Keep it short and to the point. | ||
The project is to use themoviedb.org's API to fetch a list of movies, display them on a page, and then link to a movie detail page when you click on the movie cover image. | ||
|
||
## The problem | ||
|
||
Describe how you approached to problem, and what tools and techniques you used to solve it. How did you plan? What technologies did you use? If you had more time, what would be next? | ||
We used the TMDB:s API to fetch information about the movies and build this application using React. On Monday 27th of March we started this week off with planning the project in a simple Trello-board, we've signed up for the TMDB and got access to our API-key for this project. | ||
|
||
Our goal for the week was to pair-programme as much as we can and in the end of the week we will edit this readme with more information. | ||
If we had more time for this, we would add more pages and fetch more information from other endpoints in the API. And continue to improve the overall design. | ||
|
||
## View it live | ||
|
||
Every project should be deployed somewhere. Be sure to include the link to the deployed project so that the viewer can click around and see what it's all about. | ||
Link to Netlify: https://w8-movies-team-skenfrukt-ylva-sandra.netlify.app/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Reading from stdin via: C:\Users\YLVAKA~1\AppData\Local\Temp\code-stdin-Cw7 |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,32 @@ | ||
import React from 'react'; | ||
/* eslint-disable no-trailing-spaces */ | ||
import React, { useState, useEffect } from 'react'; | ||
import { BrowserRouter, Route, Routes } from 'react-router-dom'; | ||
import MovieList from 'components/MovieList'; | ||
// import NotFound from 'components/NotFound'; | ||
// We never used this but we keep it for future usage if necessary | ||
import MovieDetails from 'components/MovieDetails'; | ||
import { BASE_URL } from 'utils/urls'; | ||
|
||
export const App = () => { | ||
const [movieList, setMovieList] = useState([]); | ||
|
||
useEffect(() => { | ||
fetch(BASE_URL) | ||
.then((data) => data.json()) | ||
.then((configuredData) => setMovieList(configuredData.results)) | ||
.catch((err) => { | ||
console.log(err); | ||
}); | ||
}, []); | ||
return ( | ||
<div> | ||
Find me in src/app.js! | ||
</div> | ||
<BrowserRouter> | ||
<Routes> | ||
<Route path="/" element={<MovieList movieList={movieList} />} /> | ||
<Route path="/details/:id" element={<MovieDetails />} /> | ||
{/* <Route path="/404" element={<NotFound />} /> | ||
<Route path="*" element={<Navigate to="/404" />} /> I removed Navigate from the | ||
import at the top since I commented this out */} | ||
</Routes> | ||
</BrowserRouter> | ||
); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mentioned this in the Demo. Maybe because you already used the word 'data' in the .then before, so it just had to be different word here?