Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W8-movies-Ylva-Karlsson-and-Sandra-Olsson #318

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
97ca9cf
Initial commit
YlvaKarlsson Mar 27, 2023
399b3f3
Commit made after trying the npm-stuff and it worked
YlvaKarlsson Mar 27, 2023
24546d5
added favicon for fun and test
SandraMadeleine Mar 27, 2023
5ba44ac
fixed a missing tag
SandraMadeleine Mar 27, 2023
e56c33e
Added some API-info
SandraMadeleine Mar 27, 2023
59e7f15
Added components
YlvaKarlsson Mar 28, 2023
6fff771
Merge branch 'master' of https://github.com/YlvaKarlsson/project-movies
YlvaKarlsson Mar 28, 2023
e7b0f57
Added components
YlvaKarlsson Mar 28, 2023
284202e
Some things are working
YlvaKarlsson Mar 28, 2023
c06cf2e
It is still working - wohoo
YlvaKarlsson Mar 28, 2023
46c360f
adding a header text and reducing header links from 4 to 2
SandraMadeleine Mar 28, 2023
dcee051
tests
SandraMadeleine Mar 28, 2023
5b79aca
fixed the movie list styling, trying to get details to show on click …
SandraMadeleine Mar 28, 2023
912e113
continued tries to get details to show
SandraMadeleine Mar 28, 2023
a2cd2c3
details now show, working on the styling for that page
SandraMadeleine Mar 29, 2023
c597090
continued fix on details
SandraMadeleine Mar 29, 2023
ada2a54
Fixed detailslink, image now much clearer
SandraMadeleine Mar 29, 2023
7bec286
media queries fixed many placement issues
SandraMadeleine Mar 29, 2023
ed1f4d3
minor fix in css
SandraMadeleine Mar 29, 2023
142867f
added some comments
SandraMadeleine Mar 29, 2023
4100bda
ylvas branch
YlvaKarlsson Mar 29, 2023
8c7e99d
Merge branch 'master' of https://github.com/YlvaKarlsson/project-movi…
YlvaKarlsson Mar 30, 2023
ca12487
test
YlvaKarlsson Mar 30, 2023
0096dc5
Nearly there
YlvaKarlsson Mar 30, 2023
357fa7a
commit to please vs code
SandraMadeleine Mar 30, 2023
e37c1b5
Merge branch 'master' of https://github.com/YlvaKarlsson/project-movies
SandraMadeleine Mar 30, 2023
0c2bb49
added footer
SandraMadeleine Mar 30, 2023
50d3301
fixed h2
SandraMadeleine Mar 30, 2023
92e13c9
fixed the rating styling to look better
SandraMadeleine Mar 30, 2023
fd09e22
minor changes
SandraMadeleine Mar 30, 2023
b59a968
Merge branch 'master' of https://github.com/YlvaKarlsson/project-movi…
YlvaKarlsson Mar 31, 2023
d1d2841
Ylvas branch with fixed footer-links
YlvaKarlsson Mar 31, 2023
45b1407
Changes made after 1:1 with Daniel
YlvaKarlsson Mar 31, 2023
d10d7c6
Deleted a comment
YlvaKarlsson Mar 31, 2023
4bff006
added prevent default
SandraMadeleine Mar 31, 2023
f41edba
Fixed footer and the links
YlvaKarlsson Mar 31, 2023
6f04d6c
Merge branch 'YlvasTestingBranch'
YlvaKarlsson Mar 31, 2023
909fcaf
Fixed readme
YlvaKarlsson Mar 31, 2023
dcf11af
final commit for now
YlvaKarlsson Apr 2, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions FETCH_HEAD
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Reading from stdin via: C:\Users\YLVAKA~1\AppData\Local\Temp\code-stdin-ZF4
11 changes: 7 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
# Project Movies

Replace this readme with your own information about your project.
This weeks project is a pair-programming-project in collaboration with Sandra Olsson and Ylva Karlsson from Team Elephants of Technigos Web Dev Boot Camp Spring 2023.

Start by briefly describing the assignment in a sentence or two. Keep it short and to the point.
The project is to use themoviedb.org's API to fetch a list of movies, display them on a page, and then link to a movie detail page when you click on the movie cover image.

## The problem

Describe how you approached to problem, and what tools and techniques you used to solve it. How did you plan? What technologies did you use? If you had more time, what would be next?
We used the TMDB:s API to fetch information about the movies and build this application using React. On Monday 27th of March we started this week off with planning the project in a simple Trello-board, we've signed up for the TMDB and got access to our API-key for this project.

Our goal for the week was to pair-programme as much as we can and in the end of the week we will edit this readme with more information.
If we had more time for this, we would add more pages and fetch more information from other endpoints in the API. And continue to improve the overall design.

## View it live

Every project should be deployed somewhere. Be sure to include the link to the deployed project so that the viewer can click around and see what it's all about.
Link to Netlify: https://w8-movies-team-skenfrukt-ylva-sandra.netlify.app/
1 change: 1 addition & 0 deletions YlvasTestingBranch
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Reading from stdin via: C:\Users\YLVAKA~1\AppData\Local\Temp\code-stdin-Cw7
191 changes: 190 additions & 1 deletion code/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion code/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,20 @@
"private": true,
"dependencies": {
"@babel/eslint-parser": "^7.18.9",
"@fortawesome/fontawesome-free": "^6.4.0",
"@fortawesome/free-brands-svg-icons": "^6.4.0",
"@fortawesome/free-solid-svg-icons": "^6.4.0",
"@fortawesome/react-fontawesome": "^0.2.0",
"eslint": "^8.21.0",
"eslint-config-airbnb": "^19.0.4",
"eslint-plugin-import": "^2.26.0",
"eslint-plugin-jsx-a11y": "^6.6.1",
"eslint-plugin-react": "^7.30.1",
"eslint-plugin-react-hooks": "^4.6.0",
"moment": "^2.29.4",
"react": "^18.2.0",
"react-dom": "^18.2.0"
"react-dom": "^18.2.0",
"react-router-dom": "^6.9.0"
},
"scripts": {
"start": "react-scripts start",
Expand Down
3 changes: 3 additions & 0 deletions code/public/images/back_arrow.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
18 changes: 6 additions & 12 deletions code/public/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,14 @@
<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<!--
Notice the use of %PUBLIC_URL% in the tags above.
It will be replaced with the URL of the `public` folder during the build.
Only files inside the `public` folder can be referenced from the HTML.

Unlike "/favicon.ico" or "favicon.ico", "%PUBLIC_URL%/favicon.ico" will
work correctly both with client-side routing and a non-root public URL.
Learn how to configure a non-root public URL by running `npm run build`.
-->
<title>Technigo React App</title>
</head>
<title>Movie Releases by Sandra & Ylva - W8 Technigo Boot Camp</title>
<meta name="description" content="A movie release project at week 8 in the Technigo Boot Camp 2023">
<link rel="icon" type="image/png" size="32x32" href="./movie-projector.png">
</head>

<body>
<!-- HERE icons credits to https://icons8.com -->
<!--icon cred: <a target="_blank" href="https://icons8.com/icon/103463/movie-projector">Movie Projector</a> icon by <a target="_blank" href="https://icons8.com">Icons8</a>-->
<noscript>You need to enable JavaScript to run this app.</noscript>
<div id="root"></div>
<!--
Expand All @@ -30,5 +25,4 @@
To create a production bundle, use `npm run build` or `yarn build`.
-->
</body>

</html>
Binary file added code/public/movie-projector.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
33 changes: 28 additions & 5 deletions code/src/App.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,32 @@
import React from 'react';
/* eslint-disable no-trailing-spaces */
import React, { useState, useEffect } from 'react';
import { BrowserRouter, Route, Routes } from 'react-router-dom';
import MovieList from 'components/MovieList';
// import NotFound from 'components/NotFound';
// We never used this but we keep it for future usage if necessary
import MovieDetails from 'components/MovieDetails';
import { BASE_URL } from 'utils/urls';

export const App = () => {
const [movieList, setMovieList] = useState([]);

useEffect(() => {
fetch(BASE_URL)
.then((data) => data.json())
.then((configuredData) => setMovieList(configuredData.results))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mentioned this in the Demo. Maybe because you already used the word 'data' in the .then before, so it just had to be different word here?

.catch((err) => {
console.log(err);
});
}, []);
return (
<div>
Find me in src/app.js!
</div>
<BrowserRouter>
<Routes>
<Route path="/" element={<MovieList movieList={movieList} />} />
<Route path="/details/:id" element={<MovieDetails />} />
{/* <Route path="/404" element={<NotFound />} />
<Route path="*" element={<Navigate to="/404" />} /> I removed Navigate from the
import at the top since I commented this out */}
</Routes>
</BrowserRouter>
);
}
}
Loading