peki's movies #326
Open
peki's movies #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoniaGranit
approved these changes
Apr 14, 2023
| // one position to the right. Then, when we use Math.round(), we round the number | ||
| // we round the number to the nearest whole number. By doing this, we are | ||
| // effectively rounding the original value to one decimal place | ||
|
|
There was a problem hiding this comment.
Good job with the commenting, it makes reading the code and your reasoning behind it so much easier!
| // FetchDetails gets movie details from an API | ||
| const FetchDetails = () => { | ||
| fetch(`https://api.themoviedb.org/3/tv/${id}?api_key=d120fe8810b0e45a06baa667dd3dc7fc&language=en-US`) | ||
| .then((response) => response.json()) |
There was a problem hiding this comment.
Perhaps you should hide your API key and make it into a variable so it isn't accessible in your repository? I just remembered me and Andreas didn't do this either.
| // FetchMovies gets popular movies from an API | ||
| const FetchMovies = () => { | ||
| setLoading(true); | ||
| fetch('https://api.themoviedb.org/3/account/18557443/watchlist/tv?api_key=d120fe8810b0e45a06baa667dd3dc7fc&session_id=d2e64114dc41e5d2079593f40f511fba80818486') |
There was a problem hiding this comment.
Great job making your own list of tv-shows! You have good taste hehe.
| }; | ||
|
|
||
| // This part shows the movie poster and title on the screen | ||
| return ( |
There was a problem hiding this comment.
I like the fact that you've made each movie in the movielist into its own component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.