. #327
. #327
Conversation
Co-authored-by: Andrea Hedström <[email protected]>
Co-authored-by: Andrea Hedström <[email protected]>
Co-authored-by: Andrea Hedström <[email protected]>
There was a problem hiding this comment.
I think you've done a great job with really nice animations and effects! I see that you've even started on the dropdown, hope you get time to incorporate that as well! There are only some small adjustments that needs to be done to the styling on the detail-page. Well fought this week 💪🏻☀️
| } | ||
| // eslint-disable-next-line no-unused-vars | ||
| const handleBackButton = (event) => { | ||
| if (event.KeyCode === 13) { |
There was a problem hiding this comment.
What does this mean? Should I be able to press Enter on the backbutton?
| }; | ||
| useEffect(() => { | ||
| FetchDetails() | ||
| }) |
There was a problem hiding this comment.
How come you did FetchDetails as a function and not put it straight in UseEffect?
| /* This return shows the img, titles, rdate & the id on our HTML page */ | ||
| return ( | ||
| <section className="startPage"> | ||
| {loading ? (<Popcorn />) : ( |
| @@ -0,0 +1,13 @@ | |||
| import React from 'react' | |||
|
|
|||
| const Popcorn = () => ( | |||
There was a problem hiding this comment.
Try to be consistent with the naming, so that the main function and file are named the same
| .header-container { | ||
| padding: 10px; | ||
| background-color: #4c0000; | ||
| cursor: url("data:image/svg+xml;utf8,<svg xmlns='http://www.w3.org/2000/svg' width='40' height='48' viewport='0 0 100 100' style='fill:black;font-size:24px;'><text y='50%'>🍿</text></svg>") |
There was a problem hiding this comment.
So fun with the cursor! A great idea!
my page