Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EvaSjoholm/Project-movies #328

Open
wants to merge 55 commits into
base: master
Choose a base branch
from
Open

Conversation

EvaSjoholm
Copy link

Doing a pull-request again

Copy link

@jenster5 jenster5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on a hard project to do alone! I mentioned a few comments below one other is just the background on the tv shows could be the same setup as the background of the movies for consistency. Other than that, great job on this project!

@@ -1,13 +1,14 @@
# Project Movies

Replace this readme with your own information about your project.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on a hard project to do alone! I mentioned a few comments below one other is just the background on the tv shows could be the same setup as the background of the movies for consistency. Other than that, great job on this project!

};
const handleMouseLeave = () => {
setIsHover(false);
};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the hover effect its a nice touch

}

p {
font-size: 24px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could try giving this one a width it is really tall in the tablet setting

margin: 10px;
width: 100px;
height: auto;
content: url(red.png)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could make this icon and the emoji the same size

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants