-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EvaSjoholm/Project-movies #328
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on a hard project to do alone! I mentioned a few comments below one other is just the background on the tv shows could be the same setup as the background of the movies for consistency. Other than that, great job on this project!
@@ -1,13 +1,14 @@ | |||
# Project Movies | |||
|
|||
Replace this readme with your own information about your project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on a hard project to do alone! I mentioned a few comments below one other is just the background on the tv shows could be the same setup as the background of the movies for consistency. Other than that, great job on this project!
}; | ||
const handleMouseLeave = () => { | ||
setIsHover(false); | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the hover effect its a nice touch
} | ||
|
||
p { | ||
font-size: 24px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could try giving this one a width it is really tall in the tablet setting
margin: 10px; | ||
width: 100px; | ||
height: auto; | ||
content: url(red.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could make this icon and the emoji the same size
Doing a pull-request again